Skip to content

feat: Add confirmation dialog to "Reset" options #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: compose-dev
Choose a base branch
from

Conversation

brosssh
Copy link
Member

@brosssh brosssh commented May 29, 2025

Closes #2537.

@brosssh brosssh requested a review from Axelen123 May 29, 2025 10:58
@brosssh brosssh added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label May 29, 2025
@brosssh brosssh linked an issue May 29, 2025 that may be closed by this pull request
4 tasks
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞🎨 UI/UX Design approved

Overall LGTM, additional comment: The current text and description of the warning dialog feels odd/robotic, I can't figure out why?

brosssh added 2 commits May 31, 2025 16:13
Added "Reset selection for app/package".
Grouped reset items into an expandable item.
Displaying also version next to bundle name.
@brosssh
Copy link
Member Author

brosssh commented Jun 2, 2025

Record_2025-06-02-14-28-21.mp4

@brosssh brosssh requested a review from Axelen123 June 2, 2025 12:30
@brosssh brosssh requested a review from Axelen123 June 4, 2025 15:05
@brosssh brosssh requested a review from Axelen123 June 4, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Dangerous option bring offered without warning
3 participants