Skip to content

build: Bump all dependencies across every ecosystems #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: compose-dev
Choose a base branch
from

Conversation

validcube
Copy link
Member

@validcube validcube commented Aug 3, 2025

Bump dependencies on every ecosystems, optimise the heck out of Gradle from 445s to 189s (on my pc) on gradle assembleDebug (clean build), and make CI work again

@@ -6,7 +6,7 @@
# http://www.gradle.org/docs/current/userguide/build_environment.html
# Specifies the JVM arguments used for the daemon process.
# The setting is particularly useful for tweaking memory settings.
org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8
org.gradle.jvmargs=-Xmx3072m -XX:MaxMetaspaceSize=1024m -Dfile.encoding=UTF-8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Metaspace arg is added is because metaspace doesn't scale with project memory allocation for some reason.

(default is 384m)

@validcube validcube marked this pull request as ready for review August 3, 2025 13:49
@Axelen123 Axelen123 added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Aug 6, 2025
Copy link
Member

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested to ensure the app isn't broken by the dependency bumps?

@validcube
Copy link
Member Author

Have you tested to ensure the app isn't broken by the dependency bumps?

Not that I know of, patching is fine, settings is fine, navigation is fine.

@validcube validcube marked this pull request as draft August 7, 2025 11:31
@validcube
Copy link
Member Author

I'll put this into draft, awaiting #2663 merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants