feat(Instagram): Added few patches #3604
Conversation
|
Does possible to download media like on Twitter (X) with long press media and download them? |
|
The added patches don't add a download patch. |
src/main/kotlin/app/revanced/patches/instagram/developerMenu/EnableDeveloperMenuPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/misc/integrations/IntegrationsPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/developerMenu/EnableDeveloperMenuPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/developerMenu/EnableDeveloperMenuPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/developerMenu/EnableDeveloperMenuPatch.kt
Outdated
Show resolved
Hide resolved
...agram/misc/links/openInExternalBrowser/fingerprints/OpenLinksInExternalBrowserFingerprint.kt
Outdated
Show resolved
Hide resolved
.../app/revanced/patches/instagram/misc/links/sanitizeSharingLinks/SanitizeSharingLinksPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/misc/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/misc/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/misc/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
|
PRs are squashed to one commit. Either separate each patch to its own PR, or squash them locally into commits called "feat(Instagram): Added |
I thought max media patch is save media into high quality. |
|
No it just changes the media quality |
oh alright, I wasnt aware of it. Lemme correct the code base with the above mentioned corrections and create PRs individually. We can probably close this one (then). |
|
Working in a single pr is easier (also to review). We can decide that once all codebase issues are resolved 👍 |
|
Hi, Updated the codebase with the mentioned comments. Let me know if it looks good now. |
src/main/kotlin/app/revanced/patches/instagram/misc/integrations/IntegrationsPatch.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/app/revanced/patches/instagram/patches/developerMenu/EnableDeveloperMenuPatch.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/app/revanced/patches/instagram/patches/developerMenu/EnableDeveloperMenuPatch.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/instagram/patches/links/openInExternalBrowser/OpenLinksInExternalBrowser.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/instagram/patches/links/openInExternalBrowser/OpenLinksInExternalBrowser.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/patches/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/patches/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/patches/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/patches/selectableBio/SelectableBioPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/instagram/patches/selectableBio/SelectableBioPatch.kt
Outdated
Show resolved
Hide resolved
|
The review will be iterative, addressing big issues, once solved, smaller issues and so on, until everything looks right. Hope it doesn't cause too much trouble. |
src/main/kotlin/app/revanced/patches/instagram/patches/maxQuality/MaxMediaQualityPatch.kt
Outdated
Show resolved
Hide resolved
|
Hi team, is there any other cleanups required from my end or the changes looks good ? |
| ) | ||
| @Suppress("unused") | ||
| object SelectableBioPatch : BytecodePatch( | ||
| setOf(SelectableBioFingerprint), |
There was a problem hiding this comment.
Please name fingerprints to the method they match to. If this one for example matches to the constructor, call it "ConstructBioViewFingerprint"
| }.name | ||
|
|
||
| // Patch the method that opens the link in the internal browser. | ||
| it.mutableClass.methods.last { it.returnType == "V" && it.parameters.size == 0 }.apply { |
There was a problem hiding this comment.
This is not a safe approach. Please fingerprint the method and get it through that.
There was a problem hiding this comment.
Basically that method originally has 4 lines, 2 const/4, 1 invoke and return-void. Moreover both the "get url" method and the method where the fragment is built is present in the same call. So I thought its easier to find the class and then find the methods accordingly
|
|
||
| import app.revanced.patcher.fingerprint.MethodFingerprint | ||
|
|
||
| internal object OpenLinksInExternalBrowserFingerprint : MethodFingerprint( |
There was a problem hiding this comment.
Name the fingerprint like explained above.
| StoryShareUrlFingerprint, | ||
| LiveShareUrlFingerprint, | ||
| PostShareClassFinderFingerprint, | ||
| ProfileShareUrlFingerprint, | ||
| HighlightsShareUrlFingerprint, |
There was a problem hiding this comment.
These fingerprints need to be named according to the method they match too
|
|
||
| override fun execute(context: BytecodeContext) { | ||
| fun sanitizeUrl(method: MutableMethod) = method.apply { | ||
| val index = getInstructions().first { it.opcode == Opcode.IPUT_OBJECT }.location.index - 2 |
There was a problem hiding this comment.
Please comment what this index does in the code
| PostShareClassFinderFingerprint.resultOrThrow().mutableMethod.let { method -> | ||
| val classIndex = method.getInstructions().last { it.opcode == Opcode.CONST_CLASS }.location.index | ||
| val className = method.getInstruction(classIndex).getReference<TypeReference>()!!.type | ||
| val parseJsonMethod = context.findClass(className)!!.mutableClass.methods.first { | ||
| it.name == "parseFromJson" | ||
| } | ||
|
|
||
| sanitizeUrl(parseJsonMethod) | ||
| } |
There was a problem hiding this comment.
Why aren't you using a fingerprint for this?
| val maxPostSize = "0x800" // Decimal value = 2048. Maximum post size. | ||
| val maxBitRate = "0x989680" // Decimal value = 10000000. Maximum bit rate possible (found in code). |
There was a problem hiding this comment.
Iirc you can use decimals just fine in smali, no need to convert to hex
| DisplayMetricsFingerprint.resultOrThrow().let { it -> | ||
| it.mutableMethod.apply { |
There was a problem hiding this comment.
If you do not use the result, simply do DisplayMetricsFingerprint.resultOrThrow().mutableMethod.
| it.mutableClass.apply { | ||
| val mediaSetMethod = | ||
| methods.first { it.returnType == "Lcom/instagram/model/mediasize/ExtendedImageUrl;" } |
There was a problem hiding this comment.
Why not fingerprint this method in the first place?
| // This section of code sets the bitrate of the stories to the max possible. | ||
| StoryMediaBitrateFingerprint.resultOrThrow().let { it -> | ||
| it.mutableMethod.apply { | ||
| val ifLezIndex = getInstructions().first { it.opcode == Opcode.IF_LEZ }.location.index |
There was a problem hiding this comment.
Use opcode patterns in fingerprint to get the index to instructions. This applies to all the other places where you manually try to find an index. Manually only makes sense if you cant fingerprint the index of a pattern properly for example due to repeating patterns.
| } | ||
|
|
||
| // Improve quality of reels. | ||
| // In general Instagram tend to set the minimum bitrate between max possible and compressed video's bitrate |
| } | ||
|
|
||
| // Improve quality of reels. | ||
| // In general Instagram tend to set the minimum bitrate between max possible and compressed video's bitrate |
There was a problem hiding this comment.
Don't short words such as "max"
LisoUseInAIKyrios
force-pushed
the
dev
branch
from
feefb56 to
a371631
Compare
oSumAtrIX
force-pushed
the
dev
branch
2 times, most recently
from
c0cd9d2 to
2ace07d
Compare
|
Is this still active? This PR is nearly done and only needs some comments and a few minor changes to bring it to completion. |
|
Hi, sorry for the late response. This PR was opened before v20 release but unfortunately, Im not getting time to migrate the code to v20. We can close this PR. I will try to open a new one or anyone can use the codebase and create one. |
|
Migrating is fairly simple, though you can continue the PR on the current base and we can take over with the migration once done. |
|
@swakwork Hi, still interested in completing this PR? |
|
I implemented most of the patches here: https://github.com/Aunali321/ReVancedExperiments/tree/main/patches/src/main/kotlin/li/auna/patches/instagram |
|
https://github.com/Aunali321/ReVancedExperiments/tree/main/patches/src/main/kotlin/li/auna/patches/instagram seems to have implemented the patches. Closing this for now. |
|
@Aunali321 Thanks a lot! Any ideas what about the mentioned download function? Also will these patches from your ExperimentPatches end up on the main Revanced Patches Repo or is this something different? |
|
No plans for download patch yet. |
Hi team,
I have added the following patches to Instagram
Enable developer menupatchMax media qualitypatchSelectable biopatchSanitize sharing linkspatchOpen links in external browserpatchI have tested these with the latest alpha build(348.0.0.0.42) , at the time, and the patches work fine.
These patches go along with my integrations PR #685
This is my first PR to this project, so do let me know if any code correction is needed.
Thanks,