-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Init #1
base: main
Are you sure you want to change the base?
chore: Init #1
Conversation
@Aunali321 Please add a description to the PR and highlight all notable additions. Explain whats missing and what we should look into for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this PR should be merged, the following should be changed:
- Contribution guidelines (Take example of ReVanced Manager & ReVanced Patches)
- Issue templates (Take example of ReVanced Manager & ReVanced Patches)
- Styles should be removed unless absolutely necessary
- Some template code is present such as example tests that should be removed (or commented)
"useTabs": true, | ||
"singleQuote": true, | ||
"trailingComma": "none", | ||
"printWidth": 100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code formatter. Same as revanced-website for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is printWidth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the line length that the printer will wrap on.
"trailingComma": "none", | ||
"printWidth": 100, | ||
"plugins": ["prettier-plugin-svelte"], | ||
"overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code formatter. Same as revanced-website for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "overrides"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overrides let you have different configuration for certain file extensions. It will override svelte's default formatting
attributes: | ||
value: | | ||
<p align="center"> | ||
<!-- add logo later --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done now.
![GitHub Workflow Status (with event)](https://img.shields.io/github/actions/workflow/status/ReVanced/revanced-web-manager/release.yml) | ||
![GPLv3 License](https://img.shields.io/badge/License-GPL%20v3-yellow.svg) | ||
|
||
Web app to use ReVanced on Web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Web app to use ReVanced on Web | |
Web application to use ReVanced |
|
||
## ❓ About | ||
|
||
ReVanced Web Manager is an web app that uses [ReVanced Patcher](https://github.com/revanced/revanced-patcher) to patch Android apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReVanced Web Manager is an web app that uses [ReVanced Patcher](https://github.com/revanced/revanced-patcher) to patch Android apps. | |
ReVanced Web Manager is a web application that uses [ReVanced Patcher](https://github.com/revanced/revanced-patcher) to patch Android apps. |
This PR includes the following updates:
What's Missing: