Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Init #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: Init #1

wants to merge 4 commits into from

Conversation

Aunali321
Copy link

@Aunali321 Aunali321 commented Apr 1, 2024

This PR includes the following updates:

  • Setting up the project structure using sveltekit
  • Updating the favicon to ReVanced logo.
  • Adding Contributing guidelines
  • Adding Issue templates
  • Updating README to be consistent with other repos.

What's Missing:

  • ReVanced branding in Issue templates, README

@oSumAtrIX
Copy link
Member

@Aunali321 Please add a description to the PR and highlight all notable additions. Explain whats missing and what we should look into for review.

@oSumAtrIX oSumAtrIX changed the title chore: Setup project structure chore: Init Apr 1, 2024
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR should be merged, the following should be changed:

  • Contribution guidelines (Take example of ReVanced Manager & ReVanced Patches)
  • Issue templates (Take example of ReVanced Manager & ReVanced Patches)
  • Styles should be removed unless absolutely necessary
  • Some template code is present such as example tests that should be removed (or commented)

"useTabs": true,
"singleQuote": true,
"trailingComma": "none",
"printWidth": 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatter. Same as revanced-website for consistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is printWidth?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the line length that the printer will wrap on.

"trailingComma": "none",
"printWidth": 100,
"plugins": ["prettier-plugin-svelte"],
"overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatter. Same as revanced-website for consistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "overrides"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overrides let you have different configuration for certain file extensions. It will override svelte's default formatting

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
playwright.config.ts Show resolved Hide resolved
src/app.scss Outdated Show resolved Hide resolved
src/index.test.ts Outdated Show resolved Hide resolved
src/lib/components/Button.svelte Outdated Show resolved Hide resolved
src/lib/components/Button.svelte Outdated Show resolved Hide resolved
static/icons/download.svg Outdated Show resolved Hide resolved
@oSumAtrIX oSumAtrIX self-requested a review April 2, 2024 19:33
attributes:
value: |
<p align="center">
<!-- add logo later -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done now.

![GitHub Workflow Status (with event)](https://img.shields.io/github/actions/workflow/status/ReVanced/revanced-web-manager/release.yml)
![GPLv3 License](https://img.shields.io/badge/License-GPL%20v3-yellow.svg)

Web app to use ReVanced on Web
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Web app to use ReVanced on Web
Web application to use ReVanced


## ❓ About

ReVanced Web Manager is an web app that uses [ReVanced Patcher](https://github.com/revanced/revanced-patcher) to patch Android apps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReVanced Web Manager is an web app that uses [ReVanced Patcher](https://github.com/revanced/revanced-patcher) to patch Android apps.
ReVanced Web Manager is a web application that uses [ReVanced Patcher](https://github.com/revanced/revanced-patcher) to patch Android apps.

@shrihankp

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants