Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add announcements #257

Draft
wants to merge 176 commits into
base: dev
Choose a base branch
from
Draft

Conversation

madkarmaa
Copy link
Member

@madkarmaa madkarmaa commented Sep 8, 2024

What's this?

This is a new, more updated continuation of #195

TODO:

@madkarmaa madkarmaa self-assigned this Sep 8, 2024
@oSumAtrIX oSumAtrIX mentioned this pull request Sep 8, 2024
5 tasks
@Ushie Ushie changed the title feat: announcements feat: Announcements Sep 8, 2024
@Ushie
Copy link
Member

Ushie commented Dec 19, 2024

Deleting tags does not behave like when creating a new announcement, they should disappear once unchecked

It has nothing to do with whether or not you're creating an announcement

Tags that already exist in the API will not disappear, tags that you've created in that draft will disappear once unchecked

@Ushie
Copy link
Member

Ushie commented Dec 19, 2024

Unread latest announcement should be shown as a banner on the website.

The banners PR is not complete

@Ushie
Copy link
Member

Ushie commented Dec 19, 2024

Nullability is not handled properly

ReVanced API seems to also not respect it

Creation:
image

Result:
image

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 20, 2024

Deleting tags does not behave like when creating a new announcement, they should disappear once unchecked

It has nothing to do with whether or not you're creating an announcement

Tags that already exist in the API will not disappear, tags that you've created in that draft will disappear once unchecked

Even if they don't disappear in the API, they do for the announcement itself. So if you uncheck a tag, it should be removed. Adding it back via the same name, would not create a new tag because it already exists. This behaviour is the same as on YouTube if you tag videos.

Unread latest announcement should be shown as a banner on the website.

The banners PR is not complete

In that case it should be looked into so that this PR can rebase onto it.

ReVanced API seems to also not respect it

The tags and attachments fields are non nullable. However I'll change that. For author the issue still applies (and once the other fields are nullable, there too)

@Ushie Ushie force-pushed the feat/announcements branch from 2003fc5 to f249af3 Compare December 22, 2024 00:44
@oSumAtrIX oSumAtrIX self-requested a review January 29, 2025 19:25
@oSumAtrIX oSumAtrIX marked this pull request as draft January 29, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants