-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add announcements #257
base: dev
Are you sure you want to change the base?
Conversation
+ update dependecies + add types + add components
+ revert queries lib to v4
…anced-website into pr/madkarmaa/257
Co-authored-by: oSumAtrIX <[email protected]>
Co-authored-by: oSumAtrIX <[email protected]>
It has nothing to do with whether or not you're creating an announcement Tags that already exist in the API will not disappear, tags that you've created in that draft will disappear once unchecked |
The banners PR is not complete |
Even if they don't disappear in the API, they do for the announcement itself. So if you uncheck a tag, it should be removed. Adding it back via the same name, would not create a new tag because it already exists. This behaviour is the same as on YouTube if you tag videos.
In that case it should be looked into so that this PR can rebase onto it.
The tags and attachments fields are non nullable. However I'll change that. For author the issue still applies (and once the other fields are nullable, there too) |
2003fc5
to
f249af3
Compare
What's this?
This is a new, more updated continuation of #195
TODO: