Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start testing on macOS and windows #234

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Start testing on macOS and windows #234

wants to merge 3 commits into from

Conversation

RealOrangeOne
Copy link
Owner

Fixes #229

@RealOrangeOne
Copy link
Owner Author

Looks like the primary issue here exists around the snapshot tests being slightly different between platforms.

I think we should remove them and replace them with more surgical examples, for more accurate testing, and using pytest.approx much more.

@trickeydan
Copy link
Contributor

Is the issue similar to #163?

@RealOrangeOne
Copy link
Owner Author

Related, but not identical. Although I suspect however we solve 1 will solve the other.

Damn guess I should get looking into all those tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run CI on macOS and Windows
2 participants
@RealOrangeOne @trickeydan