[Access Control] Fix performance issues with Redis SCAN #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jtplouffe
approved these changes
Jan 19, 2024
Contributor
Jtplouffe
left a comment
Jtplouffe
left a comment
There was a problem hiding this comment.
I think 10k might be too much, we should probably consider something like 500 or 1000, otherwise it may block the redis server for too long, and may stack up pending commends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default page size of a scan is small, 10 with my current setup.
This can cause performance issues with large Redis Databases, it will create a lot of iteration with the cursor. In some cases, it more performant to process larger pages.