Merge pull request #89 from RedHatInsights/bug/MWTELE-71

fix: MWTELE-71 report HTTP 403 as forbidden and generic report of other 4xx status
RedHatInsights · May 11, 2023 · acad0e8 · acad0e8
2 parents 25ecef9 + 9bf1984
commit acad0e8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/api/src/main/java/com/redhat/insights/InsightsErrorCode.java b/api/src/main/java/com/redhat/insights/InsightsErrorCode.java
@@ -29,7 +29,8 @@ public enum InsightsErrorCode {
   ERROR_CLIENT_FAILED(19),
   ERROR_CLIENT_BACKOFF_RETRIES_FAILED(20),
   ERROR_INTERRUPTED_THREAD(21),
-  ;
+  ERROR_HTTP_SEND_FORBIDDEN(22),
+  ERROR_HTTP_SEND_CLIENT_ERROR(23);
 
   private static final String PREFIX = "I4ASR";
   private final int code;

diff --git a/runtime/src/main/java/com/redhat/insights/core/httpclient/InsightsJdkHttpClient.java b/runtime/src/main/java/com/redhat/insights/core/httpclient/InsightsJdkHttpClient.java
@@ -162,13 +162,18 @@ protected void sendInsightsReportWithClient(
                     case 401:
                       throw new InsightsException(
                           ERROR_HTTP_SEND_AUTH_ERROR, "Authentication missing from request");
+                    case 403:
+                      throw new InsightsException(ERROR_HTTP_SEND_FORBIDDEN, "Forbidden");
                     case 413:
                       throw new InsightsException(ERROR_HTTP_SEND_PAYLOAD, "Payload too large");
                     case 415:
-                    default:
                       throw new InsightsException(
                           ERROR_HTTP_SEND_INVALID_CONTENT_TYPE,
                           "Content type of payload is unsupported");
+                    default:
+                      throw new InsightsException(
+                          ERROR_HTTP_SEND_CLIENT_ERROR,
+                          "Client error with HTTP status code " + statusCode);
                   }
                 case 5:
                 default: