fix(bug): fix circular structure error in user activation toggle

[shannon-donahue]

Description

description text...

RHCLOUDXXXX

---

Screenshots

Before:

After:

---

Checklist ☑️

• PR only fixes one issue or story
• Change reviewed for extraneous code
• UI best practices adhered to
• Commits squashed and meaningfully named
• All PR checks pass locally (build, lint, test, E2E)

• (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
• (Optional) QE: Has been mentioned
• (Optional) UX: Needs UX attention (end user UX modified, missing designs)
• (Optional) UX: Has been mentioned

Summary by Sourcery

Bug Fixes:

• Fix circular structure error in user activation toggle by removing the event parameter from toggleUserActivationStatus and adjusting its calls

[sourcery-ai]

Reviewer's Guide

Refactor the toggleUserActivationStatus helper to drop the event argument and update all its invocations accordingly to only accept activation status and user list.

Sequence Diagram: Updated Invocation of toggleUserActivationStatus

sequenceDiagram
    actor User
    participant UsersListItless

    User->>UsersListItless: Triggers action (e.g., confirms deactivation via UI)
    UsersListItless->>UsersListItless: confirmDeactivateUsers()
    UsersListItless->>UsersListItless: toggleUserActivationStatus(false, selectedRows)

Loading

Class Diagram: Update to UsersListItless Component Methods

classDiagram
  class UsersListItless {
    +toggleUserActivationStatus(isActivated: boolean, users: Array): void
    +confirmDeactivateUsers(): void
  }

Loading

File-Level Changes

Change	Details	Files
Simplify toggleUserActivationStatus API by removing the event parameter	Remove _event parameter from the function signature Adjust calls in confirmDeactivateUsers to drop the null placeholder Update toolbar dropdown handler to pass only (status, users) Modify checkbox onChange to supply just (checked, users)	src/smart-components/group/add-group/users-list-itless.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @shannon-donahue - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}