Skip to content

adopting the shared pipeline design #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: security-compliance
Choose a base branch
from

Conversation

ryemorris
Copy link
Contributor

@ryemorris ryemorris commented Jun 25, 2025

Summary by Sourcery

Adopt a shared pipeline design by replacing the bespoke inline pipeline specs with a reference to a centralized Konflux Tekton pipeline for both pull-request and push triggers, and update related annotations and parameters.

Enhancements:

  • Replace embedded pipelineSpec definitions in PR and push YAMLs with a pipelineRef to the shared docker-build-run-unit-tests pipeline.
  • Add a unit-tests-script parameter and update the dockerfile path to ./build-tools/Dockerfile for both pipelines.
  • Update Pipelines as Code annotations to point to the external pipeline URL and remove the cancel-in-progress setting.

Chores:

  • Remove hundreds of lines of custom task and parameter definitions now provided by the shared pipeline.

shannon-donahue and others added 5 commits June 4, 2025 09:33
fix(bug): fix circular structure error in user activation toggle
…sights-rbac-ui-sc

Red Hat Konflux update insights-rbac-ui-sc
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@ryemorris ryemorris requested a review from a team as a code owner June 25, 2025 03:43
Copy link
Contributor

sourcery-ai bot commented Jun 25, 2025

Reviewer's Guide

This PR refactors the Insights RBAC UI Tekton pipelines by replacing the embedded pipelineSpec definitions with a shared external pipeline reference, updates annotations accordingly, and adds a new unit-tests-script alongside minor path tweaks.

File-Level Changes

Change Details Files
Replaced inline pipelineSpec with shared pipelineRef
  • Removed entire embedded pipelineSpec blocks
  • Introduced pipelineRef: name/docker-build and external pipeline URL annotation
.tekton/insights-rbac-ui-sc-pull-request.yaml
.tekton/insights-rbac-ui-sc-push.yaml
Updated Pipelines-as-Code annotations
  • Removed cancel-in-progress settings
  • Added pipelinesascode.tekton.dev/pipeline pointing to shared konflux-pipelines URL
.tekton/insights-rbac-ui-sc-pull-request.yaml
.tekton/insights-rbac-ui-sc-push.yaml
Added unit-tests-script parameter
  • Introduced unit-tests-script with npm install, lint, and test commands
  • Ensured the script is included in both pull-request and push pipeline configs
.tekton/insights-rbac-ui-sc-pull-request.yaml
.tekton/insights-rbac-ui-sc-push.yaml
Adjusted Dockerfile path parameter
  • Prefixed dockerfile value with './' to reflect new project structure
.tekton/insights-rbac-ui-sc-pull-request.yaml
.tekton/insights-rbac-ui-sc-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ddonahue007 ddonahue007 force-pushed the security-compliance branch from 79c307d to 65d3ae4 Compare June 26, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants