-
Notifications
You must be signed in to change notification settings - Fork 49
feat(workspaces): initial pass at workspace permission utility #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
florkbr
wants to merge
2
commits into
RedHatInsights:master
Choose a base branch
from
florkbr:workspace-selector-permissions-enforcement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(workspaces): initial pass at workspace permission utility #1865
florkbr
wants to merge
2
commits into
RedHatInsights:master
from
florkbr:workspace-selector-permissions-enforcement
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR introduces a workspace permissions utility hook and integrates it into the ManagedSelector component by extending the data fetcher and tree builder to conditionally disable inaccessible workspaces based on user permissions. Class diagram for WorkspacePermissions utility and integrationclassDiagram
class WorkspacePermissions {
<<enum>>
AllPermission
ReadPermission
WritePermission
}
class WorkspacePermissionsObject {
<<type>>
[WorkspacePermissions]: ResourceDefinition[]
}
class useWorkspacePermissions {
+[WorkspacePermissionsObject, Error|undefined] useWorkspacePermissions()
}
class canViewWorkspaceById {
+boolean canViewWorkspaceById(workspaceId: string, workspacePermissions: WorkspacePermissionsObject)
}
class ManagedSelector {
+withPermissions: boolean
}
class ManagedSelectorInternal {
+withPermissions: boolean
}
class createWorkspaceDataFetcher {
+function(storeActions, workspacePermissions)
}
class buildWorkspaceTree {
+function(wps: Workspace[], workspacePermissions: WorkspacePermissionsObject|undefined)
}
class TreeViewWorkspaceItem {
+parentTreeViewItem?: TreeViewWorkspaceItem
+workspace: Workspace
+disabled?: boolean
}
WorkspacePermissionsObject o-- WorkspacePermissions
useWorkspacePermissions ..> WorkspacePermissionsObject
canViewWorkspaceById ..> WorkspacePermissionsObject
ManagedSelector --> ManagedSelectorInternal
ManagedSelectorInternal ..> useWorkspacePermissions
ManagedSelectorInternal ..> createWorkspaceDataFetcher
createWorkspaceDataFetcher ..> buildWorkspaceTree
buildWorkspaceTree ..> WorkspacePermissionsObject
buildWorkspaceTree ..> TreeViewWorkspaceItem
TreeViewWorkspaceItem --> Workspace
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
…r-permissions-enforcement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds workspace permissions utility hook and ties into the managed selector component.
https://issues.redhat.com/browse/RHCLOUD-40591
Screenshots
Before (or with
withPermissions
set tofalse
onManagedSelector
props):After:
Checklist ☑️
Summary by Sourcery
Add a workspace permissions utility and integrate it into the ManagedSelector to filter and disable unauthorized workspace entries
New Features:
Enhancements: