Develop: Rebase for OCP resource cleanup on AWS

[jyejare]

Rebasing #134 with Develop branch.

[oharan2]

Might not want to use else since the cleanup can be set to execute OCPs and other resources as well (or use kwargs["_all"])

[jyejare]

Do you see a scenario where OCPs and other resources in the list would be called at the same time for cleanup. ?

If yes, we should rather say ocp-clusters to be more specific, so it would look like a resource type within AWS provider.

I thought it is good to keep OCP cluster cleanup separate from other resources cleanup as cluster cleanup will anyways cleanup what it suppose to.

Thoughts ?

[oharan2]

Following the last comment, since the cleanup can be executed on multiple resources (OCPs and others), I think the if is_dry_run: component should be outside both sections and appear once only, post all resources cleanup executions.

Suggested change

	if is_dry_run:
	echo_dry(dry_data)
	if is_dry_run:
	echo_dry(dry_data)

[jyejare]

The dry run printing here is per region basis hence having it within a loop makes sense.

If we make it at the end of loop it will only print resources from the last region only as a buggy behavior .

[jyejare]

Will take a look on the comments tomorrow in brief but did you see any logical failures via static check or execution ?

[oharan2]

Will take a look on the comments tomorrow in brief but did you see any logical failures via static check or execution ?

Edit: links in this comment breaked due to force push

Other than the "else" I noted (will break any cleanup contains with both OCPs and other types of AWS resources);

The only thing I suscpected is here, needs to be approachable in any case.

I thought it maybe should be self.dry_data['OCPS']['delete'] when self.dry_data[] will be set in the level of providerclenaup instead of here. Unless it's already verified.

[jyejare]

@oharan2 We will make the dry run and in general reporting improvements as a next goal. But for now we should be good to go.

Also could you find the time to validate this code on actual cleanup ?

[oharan2]

The new create_html command breaks with the OCP outputs.
HERE the function expects an str but the dry data from OCPs are dicts, Logs sent privately.