[Virt] Swap to correct device for s390x when mounting device in tests/virt/cluster/service_account/test_service_account.py

[jdao-rh]

Short description:

Swaps to correct device /dev/vdb when mounting for the s390x image in test case tests/virt/cluster/service_account/test_service_account.py

More details:

What this PR does / why we need it:

Allows test tests/virt/cluster/service_account/test_service_account.py to be run correctly on s390x arch

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests
  • Tests now adapt to architecture-specific device naming so VM validation runs correctly on s390x and other architectures.
  • Added an automatic cluster-architecture detection fixture to streamline running tests across different environments.

[coderabbitai]

Walkthrough

Adds an s390x detection fixture and updates a VM service-account test to accept that fixture and choose the block device path (/dev/vdb for s390x, /dev/sda otherwise) when mounting during the test.

Changes

Cohort / File(s)	Change Summary
Test update tests/virt/cluster/service_account/test_service_account.py	Test test_vm_with_specified_service_account signature changed to accept is_s390x_cluster; introduces mount_device set to /dev/vdb when true else /dev/sda, and uses it in SSH mounting commands.
Fixture addition tests/conftest.py	Added import of S390X and a new session-scoped pytest fixture is_s390x_cluster(nodes_cpu_architecture) returning whether cluster architecture equals S390X.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cda5cf1 and b7840d6.

📒 Files selected for processing (1)

• tests/virt/cluster/service_account/test_service_account.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/virt/cluster/service_account/test_service_account.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: build-container
• GitHub Check: tox
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/11991

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/11992

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/11994

[openshift-virtualization-qe-bot-2]

Report bugs in Issues

The following are automatically added:

• Add reviewers from OWNER file (in the root of the repository) under reviewers section.
• Set PR size label.
• New issue is created for the PR. (Closed when PR is merged/closed)
• Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

• To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
• To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
  • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
  • Cherry-pick will be started when PR is merged
• To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • You can add extra args to the Podman build command
    • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
• To add a label by comment use /<label name>, to remove, use /<label name> cancel
• To assign reviewers based on OWNERS file use /assign-reviewers
• To check if PR can be merged use /check-can-merge
• to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

• /approve from one of the approvers.
• Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

• Approvers:

  • dshchedr
  • vsibirsk

• Reviewers:

  • SiboWang1997
  • akri3i
  • dshchedr
  • jerry7z
  • kbidarkar
  • vsibirsk

Supported /retest check runs

• /retest tox: Retest tox
• /retest build-container: Retest build-container
• /retest all: Retest all

Supported labels

• hold
• verified
• wip
• lgtm
• approve

[jdao-rh]

/verified

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/15487

[jdao-rh]

tests removed on main, closing pr