CherryPicked: [cnv-4.18] Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) #1140

OhadRevah · 2025-06-04T10:00:49Z

Short description:

Fixed MemoryDeltaFromRequestedBytes tests by coverting
the fixtures used into utils that used in sampler so the expected
value will be updated, before the expected value pulled one time
and sometime it is higher than the metric value and it needs to be
updated.

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

https://issues.redhat.com/browse/CNV-62973

* Fix MemoryDeltaFromRequestedBytes tests flakiness Fixed MemoryDeltaFromRequestedBytes tests by coverting the fixtures used into utils that used in sampler so the expected value will be updated, before the expected value pulled one time and sometime it is higher than the metric value and it needs to be updated. * Update tests/observability/metrics/utils.py Co-authored-by: Den Shchedrivyi <[email protected]> * Refactored functions and vars names Renamed functions and vars according to comments. * Combined expected kubvievirt memory delta functions * Combine MemoryDeltaFromRequestedBytes tests under the same test with parametrize. * changed get_highest_memory_usage_virt_api_pod_dict to return tuple * Fixed get_metrics_value --------- Co-authored-by: Den Shchedrivyi <[email protected]>

coderabbitai · 2025-06-04T10:00:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

openshift-virtualization-qe-bot-2 · 2025-06-04T10:01:02Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
- You can add extra args to the Podman build command
  - Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge
to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

/approve from one of the approvers.
Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

Approvers:
- dshchedr
- dshchedr
- myakove
- rnetser
- rnetser
- vsibirsk
- vsibirsk
Reviewers:
- OhadRevah
- RoniKishner
- RoniKishner
- dshchedr
- dshchedr
- geetikakay
- hmeir
- rnetser
- rnetser
- vsibirsk
- vsibirsk

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container
/retest all: Retest all

Supported labels

hold
verified
wip
lgtm
approve

OhadRevah · 2025-06-04T11:43:54Z

/build-and-push-container

openshift-virtualization-qe-bot-3 · 2025-06-04T11:44:43Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-1140 published

OhadRevah · 2025-06-04T12:14:15Z

/verified

rnetser · 2025-06-04T12:31:23Z

/approve
/lgtm

OhadRevah · 2025-06-04T13:17:13Z

/retest build-container

openshift-virtualization-qe-bot-2 · 2025-06-05T06:09:19Z

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-1140.

openshift-virtualization-qe-bot-2 · 2025-06-05T06:15:04Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.18 published

OhadRevah and others added 2 commits June 4, 2025 12:48

Merge branch 'cnv-4.18' into fixMemoryDeltaFromRequestedBytes

fda28a1

openshift-virtualization-qe-bot-2 requested a review from RoniKishner June 4, 2025 10:01

openshift-virtualization-qe-bot-2 assigned OhadRevah Jun 4, 2025

openshift-virtualization-qe-bot-2 mentioned this pull request Jun 4, 2025

Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) - 1140 #1141

Closed

openshift-virtualization-qe-bot-2 requested review from dshchedr and rnetser June 4, 2025 10:01

openshift-virtualization-qe-bot-2 added branch-cnv-4.18 size/L labels Jun 4, 2025

openshift-virtualization-qe-bot requested a review from hmeir June 4, 2025 10:01

openshift-virtualization-qe-bot-2 requested review from vsibirsk and geetikakay June 4, 2025 10:01

OhadRevah changed the title ~~Fix MemoryDeltaFromRequestedBytes tests flakiness (#762)~~ CherryPicked: [cnv-4.18] Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) Jun 4, 2025

openshift-virtualization-qe-bot approved these changes Jun 4, 2025

View reviewed changes

openshift-virtualization-qe-bot added tox:verify-bugs-are-open:passed D/S Testing and removed tox:verify-bugs-are-open:passed D/S Testing labels Jun 4, 2025

openshift-virtualization-qe-bot-2 added the lgtm-openshift-virtualization-qe-bot label Jun 4, 2025

openshift-virtualization-qe-bot added the verified label Jun 4, 2025

openshift-virtualization-qe-bot added approved-rnetser lgtm-rnetser labels Jun 4, 2025

hmeir approved these changes Jun 4, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-hmeir label Jun 4, 2025

openshift-virtualization-qe-bot-2 added the can-be-merged label Jun 4, 2025

dshchedr approved these changes Jun 4, 2025

View reviewed changes

openshift-virtualization-qe-bot-2 added the lgtm-dshchedr label Jun 4, 2025

rnetser merged commit 1b0ce98 into RedHatQE:cnv-4.18 Jun 5, 2025
8 checks passed

OhadRevah deleted the fixMemoryDeltaFromRequestedBytes branch June 8, 2025 10:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CherryPicked: [cnv-4.18] Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) #1140

CherryPicked: [cnv-4.18] Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) #1140

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

coderabbitai bot commented Jun 4, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 4, 2025

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Jun 4, 2025

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

rnetser commented Jun 4, 2025

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 5, 2025

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 5, 2025

Uh oh!

Uh oh!

CherryPicked: [cnv-4.18] Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) #1140

CherryPicked: [cnv-4.18] Fix MemoryDeltaFromRequestedBytes tests flakiness (#762) #1140

Uh oh!

Conversation

OhadRevah commented Jun 4, 2025

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai bot commented Jun 4, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 4, 2025

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Jun 4, 2025

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

rnetser commented Jun 4, 2025

Uh oh!

OhadRevah commented Jun 4, 2025

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 5, 2025

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 5, 2025

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)