[virt] Add migration rights test cases

[vsibirsk]

Short description:

• Migration with namespace admin without migration role
• Migration with namespace admin with migration role

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

https://issues.redhat.com/browse/CNV-62499

Summary by CodeRabbit

• Tests
  • Added new tests verifying VM migration permissions for unprivileged users with and without specific role bindings.
• New Features
  • Enhanced RBAC test coverage for VM migration scenarios.
• Chores
  • Updated VM migration utilities to support optional client specification.

[coderabbitai]

"""

Walkthrough

This change introduces new RBAC-focused tests for VM migration rights in a Kubernetes environment and updates the migrate_vm_and_verify utility to accept an optional client parameter. The tests validate migration permissions for unprivileged users, while the utility function is enhanced for client-specific operations.

Changes

File(s)	Change Summary
tests/virt/cluster/migration_and_maintenance/rbac_hardening/test_migration_rights.py	New test module with fixtures and two tests for RBAC migration rights using unprivileged clients.
utilities/virt.py	Added optional client parameter to migrate_vm_and_verify and updated its usage and docstring.

Possibly related PRs

• utilities, virt: Add typing to the 'migrate_vm_and_verify' helper #990: Related due to changes involving type annotations and function signature adjustments for migrate_vm_and_verify.

Suggested labels

verified, size/XS, can-be-merged, lgtm-rnetser, approved-rnetser

Suggested reviewers

• vsibirsk
• dshchedr
• rnetser
  """

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86088db and 48b25d4.

📒 Files selected for processing (1)

• tests/virt/cluster/migration_and_maintenance/rbac_hardening/test_migration_rights.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/virt/cluster/migration_and_maintenance/rbac_hardening/test_migration_rights.py

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: build-container
• GitHub Check: tox
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-virtualization-qe-bot-2]

Report bugs in Issues

The following are automatically added:

• Add reviewers from OWNER file (in the root of the repository) under reviewers section.
• Set PR size label.
• New issue is created for the PR. (Closed when PR is merged/closed)
• Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

• To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
• To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
  • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
  • Cherry-pick will be started when PR is merged
• To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • You can add extra args to the Podman build command
    • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
• To add a label by comment use /<label name>, to remove, use /<label name> cancel
• To assign reviewers based on OWNERS file use /assign-reviewers
• To check if PR can be merged use /check-can-merge
• to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

• /approve from one of the approvers.
• Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

• Approvers:

  • dshchedr
  • dshchedr
  • dshchedr
  • myakove
  • rnetser
  • rnetser
  • vsibirsk
  • vsibirsk
  • vsibirsk

• Reviewers:

  • RoniKishner
  • RoniKishner
  • SiboWang1997
  • akri3i
  • dshchedr
  • dshchedr
  • dshchedr
  • geetikakay
  • jerry7z
  • kbidarkar
  • rnetser
  • rnetser
  • vsibirsk
  • vsibirsk
  • vsibirsk

Supported /retest check runs

• /retest tox: Retest tox
• /retest build-container: Retest build-container
• /retest all: Retest all

Supported labels

• hold
• verified
• wip
• lgtm
• approve

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/12280

[vsibirsk]

/verified

[vsibirsk]

/verified

[dshchedr]

/lgtm
/approve

[openshift-virtualization-qe-bot-2]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published