[Virt] Add s390x centos images #1212

jdao-rh · 2025-06-13T18:44:49Z

Short description:

Adds centos images for s390x tests

More details:

What this PR does / why we need it:

Adds centos images for s390x tests

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

coderabbitai · 2025-06-13T18:44:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

openshift-virtualization-qe-bot · 2025-06-13T19:06:55Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
- You can add extra args to the Podman build command
  - Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge
to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

/approve from one of the approvers.
Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

Approvers:
- dshchedr
- dshchedr
- myakove
- rnetser
- rnetser
- vsibirsk
- vsibirsk
Reviewers:
- RoniKishner
- RoniKishner
- dshchedr
- dshchedr
- geetikakay
- rnetser
- rnetser
- vsibirsk
- vsibirsk

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container
/retest all: Retest all

Supported labels

hold
verified
wip
lgtm
approve

openshift-virtualization-qe-bot-2 · 2025-06-15T16:55:48Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
- You can add extra args to the Podman build command
  - Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge
to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

/approve from one of the approvers.
Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

Approvers:
- dshchedr
- dshchedr
- myakove
- rnetser
- rnetser
- vsibirsk
- vsibirsk
Reviewers:
- RoniKishner
- RoniKishner
- dshchedr
- dshchedr
- geetikakay
- rnetser
- rnetser
- vsibirsk
- vsibirsk

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container
/retest all: Retest all

Supported labels

hold
verified
wip
lgtm
approve

tests/global_config_s390x.py

geetikakay · 2025-06-16T13:02:05Z

tests/global_config_s390x.py

 rhel_os_matrix = generate_os_matrix_dict(os_name="rhel", supported_operating_systems=["rhel-9-5"])
 fedora_os_matrix = generate_os_matrix_dict(os_name="fedora", supported_operating_systems=["fedora-41"])
+centos_os_matrix = generate_os_matrix_dict(os_name="centos", supported_operating_systems=["centos-stream-9"])


instead of duplicating it in all global_config_arch for s390x and x86 , have it in global_config.py . global config should take care of rest

we moved it out of global_config into arch specific config for a reason.
not all arch will have those matrix (for e.g. arm64 doesn't have centos images now)
so moving it to global_config means arm test run will also get it (and will cause potential issues)

https://quay.io/repository/centos/centos?tab=tags but this shows arm64 images for centos

@geetikakay we cannot assume we have image support for all architectures. it should be easy to see (under the relevant arch file what is supported). for multi-arch we will need to some more work)

@rnetser thanks for explaining it better, I agree we should handle based on arch but noticed that centos and fedora are same across all global_config files irrespective of arch so just want to avoid duplication.
Regarding centos arm, since we already have an effort to support and run ARM setup's, would it make sense to follow this in a jira ticket?

any effort should be tracked

some references can be find here : https://issues.redhat.com/browse/CNV-24604 & https://quay.io/repository/containerdisks/centos-stream?tab=tags

rnetser · 2025-06-17T09:34:28Z

/approve
/lgtm

jdao-rh · 2025-06-19T13:08:47Z

/verified

addressed

openshift-virtualization-qe-bot · 2025-06-22T16:56:50Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:s390x published

Added s390x centos images

6fb42bf

openshift-virtualization-qe-bot previously approved these changes Jun 13, 2025

View reviewed changes

jdao-rh marked this pull request as ready for review June 13, 2025 19:06

jdao-rh marked this pull request as draft June 13, 2025 19:06

openshift-virtualization-qe-bot requested a review from RoniKishner June 13, 2025 19:06

openshift-virtualization-qe-bot assigned jdao-rh Jun 13, 2025

openshift-virtualization-qe-bot requested a review from dshchedr June 13, 2025 19:06

openshift-virtualization-qe-bot added the branch-s390x label Jun 13, 2025

openshift-virtualization-qe-bot requested a review from geetikakay June 13, 2025 19:07

openshift-virtualization-qe-bot added the size/XS label Jun 13, 2025

openshift-virtualization-qe-bot requested review from vsibirsk and rnetser June 13, 2025 19:07

jdao-rh marked this pull request as ready for review June 15, 2025 16:55

rnetser previously requested changes Jun 16, 2025

View reviewed changes

tests/global_config_s390x.py Outdated Show resolved Hide resolved

openshift-virtualization-qe-bot-2 added the changes-requested-rnetser label Jun 16, 2025

geetikakay reviewed Jun 16, 2025

View reviewed changes

openshift-virtualization-qe-bot-3 added the commented-geetikakay label Jun 16, 2025

Added latest_centos_os_dict

9d3f32d

jdao-rh dismissed openshift-virtualization-qe-bot’s stale review via 9d3f32d June 16, 2025 15:03

openshift-virtualization-qe-bot-3 removed changes-requested-rnetser commented-geetikakay labels Jun 16, 2025

openshift-virtualization-qe-bot approved these changes Jun 16, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-openshift-virtualization-qe-bot label Jun 16, 2025

dshchedr approved these changes Jun 16, 2025

View reviewed changes

openshift-virtualization-qe-bot-2 added the lgtm-dshchedr label Jun 16, 2025

openshift-virtualization-qe-bot-3 added the commented-geetikakay label Jun 16, 2025

openshift-virtualization-qe-bot-2 added the commented-rnetser label Jun 17, 2025

openshift-virtualization-qe-bot added approved-rnetser lgtm-rnetser labels Jun 17, 2025

vsibirsk approved these changes Jun 19, 2025

View reviewed changes

openshift-virtualization-qe-bot-3 added the lgtm-vsibirsk label Jun 19, 2025

openshift-virtualization-qe-bot-2 added the verified label Jun 19, 2025

openshift-virtualization-qe-bot-3 added the can-be-merged label Jun 19, 2025

rnetser merged commit 1de564e into RedHatQE:s390x Jun 22, 2025
8 checks passed

[Virt] Add s390x centos images #1212

[Virt] Add s390x centos images #1212

Uh oh!

Conversation

jdao-rh commented Jun 13, 2025

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

openshift-virtualization-qe-bot commented Jun 13, 2025

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 15, 2025

Uh oh!

Uh oh!

geetikakay Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

vsibirsk Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

geetikakay Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

rnetser Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

geetikakay Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

rnetser Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

geetikakay Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rnetser commented Jun 17, 2025

Uh oh!

jdao-rh commented Jun 19, 2025

Uh oh!

Uh oh!

openshift-virtualization-qe-bot commented Jun 22, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

geetikakay Jun 19, 2025 •

edited

Loading