Change RHEL Image name into test_import_http.py by josemacassan · Pull Request #1215 · RedHatQE/openshift-virtualization-tests

josemacassan · 2025-06-16T09:49:14Z

Short description:

Update RHEL image name into test tests/storage/test_import_http.py

More details:

Suggestion coming from CherryPick PR, see comment: #1201 (review)

What this PR does / why we need it:

Change image name for RHEL8_2_IMG to other name

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Tests
- Updated a test to use a fixed virtual machine name when creating a VM from a DataVolume.
Chores
- Removed an outdated virtual machine image constant from the system.

openshift-virtualization-qe-bot · 2025-06-16T09:49:26Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
- You can add extra args to the Podman build command
  - Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge
to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

/approve from one of the approvers.
Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

Approvers:
- jpeimer
Reviewers:
- duyanyan
- jpeimer

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container
/retest all: Retest all

Supported labels

hold
verified
wip
lgtm
approve

coderabbitai · 2025-06-16T09:49:56Z

"""

Walkthrough

The test function test_vm_from_dv_on_different_node in tests/storage/cdi_import/test_import_http.py was updated to replace the VM name constant with a fixed string "rhel-vm". The constant RHEL8_2_IMG was removed from the Rhel class in utilities/constants.py. No other logic changes were made.

Changes

File(s)	Change Summary
tests/storage/cdi_import/test_import_http.py	Replaced VM name constant with string literal `"rhel-vm"` in test.
utilities/constants.py	Removed `RHEL8_2_IMG` constant from `Rhel` class under `ArchImages.X86_64`.

Possibly related PRs

Storage: update RHEL8 images to latest #1193: Updates tests to replace hardcoded RHEL8 image constants with a dynamic latest image path, related to modifying RHEL8 image references in tests.

Suggested labels

can-be-merged, lgtm-RoniKishner

Suggested reviewers

jpeimer
duyanyan
RoniKishner
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be49196 and 8c872c8.

📒 Files selected for processing (1)

utilities/constants.py (0 hunks)

💤 Files with no reviewable changes (1)

utilities/constants.py

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: can-be-merged
GitHub Check: can-be-merged
GitHub Check: tox
GitHub Check: build-container

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

josemacassan · 2025-06-16T12:08:30Z

/verified

jpeimer · 2025-06-17T07:19:04Z

/approve
/lgtm

rnetser · 2025-06-17T09:06:05Z

/approve
/lgtm

openshift-virtualization-qe-bot-2 · 2025-06-17T09:10:28Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

josemacassan · 2025-06-17T09:11:57Z

/cherry-pick cnv-4.18

openshift-virtualization-qe-bot-3 · 2025-06-17T09:12:16Z

Manual cherry-pick is needed
Cherry pick failed for 13c8e0f to cnv-4.18:
To cherry-pick run:

git remote update
git checkout cnv-4.18
git pull origin cnv-4.18
git checkout -b update_rhel8_name-cnv-4.18
git cherry-pick 13c8e0fcf54205926412246461ccf3ba6137491d
git push origin update_rhel8_name-cnv-4.18

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

* Change RHEL Image name into test_import_http.py (#1215) * Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant * Cherry-pick cleanup * Cleanup cherry-pick * Remove unused rhel image into utilities/constants.py

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

* Refactor arch s390x branch (#1199) * feat: refactor image architectures * fix versions and refactor functio location * get os from py_config only if exists * add missing file * fix tox and use global_config_x86.py * add todo on cirros s390x class * catch AttributeError it not set * catch AttributeError it not set * catch AttributeError it not set * update get_test_images_arch_class to upper * address comments and refactor archs * Move base images to data classes * add markers to pytest.ini * address comments * address review comments * add to tox * fix tox * update markers description * address comments * fix dataclasses * add OS_VERSION_STR to all * add docstrings * fix pre-commit * fix missing matrix flows * update gcp ini file * fix windows dir * fix dir assignment * update readme * re-add removed test * Replace hardcoded image size (#1207) * feat: mark some s390x compute tests as working (#1202) Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Update http server (#1222) * test: enable more tests for s390x (#1221) - test_vmi_annotations - test_deprecated_apis_in_audit_logs Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Fix TestVmiNetworkMetricsLinux tests flakiness (#1188) Fixing the tests that failed under TestVmiNetworkMetricsLinux. * Update test_vhostmd.py to use file based on architecture (#1170) Signed-off-by: Roni Kishner<rkishner@redhat.com> * Change RHEL Image name into test_import_http.py (#1215) * Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant * network tests: add hardware markers wherever there is special_infra (#1191) We strive to remove special_infra marker for all tests, this PR adds the use of available network hardware markers wherever there is a special_infra marker and guarantees an interchangeability. New markers are not needed in this case, we already have sriov and jumbo_frame. jira-ticket: https://issues.redhat.com/browse/CNV-62769 Signed-off-by: Sergei Volkov <sevolkov@redhat.com> * [Chaos] Fix test_ceph_storage_outage timeout failure (#1208) In ODF 4.18, the csi-rbdplugin-provisioner Deployment managed RBD volume provisioning. In ODF 4.19, this component was replaced by openshift-storage.rbd.csi.ceph.com-ctrlplugin, \ which follows a standardized naming convention for CSI drivers. The new controller cannot be scaled down to 0 (it is immediately recreated by the Operator). This makes the previous testing approach (disabling the provisioner to simulate outages) no longer viable. To validate storage resilience, we now target other ODF components for disruption, such as: ceph-csi-controller-manager and odf-operator-controller-manager. Components like rook-ceph-operator, ocs-operator, and rook-ceph-osd are not retested here.\ (Their failure modes are already covered in test_migration.py). Signed-off-by: Qixuan Wang <qwang@redhat.com> * Storage: tests for storage migration of VM with hotplugged volume (#1160) * Storage: tests for storage migration of VM with hotplugged volume * address comments, add client, use ssh instead of console * Split test - verify hotplugged disk data * Fix fixture calls after test split * resolve conflicts * fix tox * use cluster arch * use resouece const * remove unused file * remove architecture leftovers * add centos support * add s390x marker on more tests * rename s390x fedora image name * address review comments * ause only one global_config * use only global config * fix leftovers in global configs * add missing check in tox * update how we extract latest instance type from os * update readme * fix instance type for arm * use const for windows * remove removed rhal versions * use X86_64 * add constants --------- Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> Signed-off-by: Roni Kishner<rkishner@redhat.com> Signed-off-by: Sergei Volkov <sevolkov@redhat.com> Signed-off-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Kirk Crane <kcrane@redhat.com> Co-authored-by: Nestor Acuna Blanco <37973744+nestoracunablanco@users.noreply.github.com> Co-authored-by: Ohad Revah <orevah@redhat.com> Co-authored-by: Roni Kishner <87259550+RoniKishner@users.noreply.github.com> Co-authored-by: Jose Manuel Castano <73908807+josemacassan@users.noreply.github.com> Co-authored-by: Sergei Volkov <153028767+servolkov@users.noreply.github.com> Co-authored-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>

* Refactor arch s390x branch (RedHatQE#1199) * feat: refactor image architectures * fix versions and refactor functio location * get os from py_config only if exists * add missing file * fix tox and use global_config_x86.py * add todo on cirros s390x class * catch AttributeError it not set * catch AttributeError it not set * catch AttributeError it not set * update get_test_images_arch_class to upper * address comments and refactor archs * Move base images to data classes * add markers to pytest.ini * address comments * address review comments * add to tox * fix tox * update markers description * address comments * fix dataclasses * add OS_VERSION_STR to all * add docstrings * fix pre-commit * fix missing matrix flows * update gcp ini file * fix windows dir * fix dir assignment * update readme * re-add removed test * Replace hardcoded image size (RedHatQE#1207) * feat: mark some s390x compute tests as working (RedHatQE#1202) Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Update http server (RedHatQE#1222) * test: enable more tests for s390x (RedHatQE#1221) - test_vmi_annotations - test_deprecated_apis_in_audit_logs Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Fix TestVmiNetworkMetricsLinux tests flakiness (RedHatQE#1188) Fixing the tests that failed under TestVmiNetworkMetricsLinux. * Update test_vhostmd.py to use file based on architecture (RedHatQE#1170) Signed-off-by: Roni Kishner<rkishner@redhat.com> * Change RHEL Image name into test_import_http.py (RedHatQE#1215) * Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant * network tests: add hardware markers wherever there is special_infra (RedHatQE#1191) We strive to remove special_infra marker for all tests, this PR adds the use of available network hardware markers wherever there is a special_infra marker and guarantees an interchangeability. New markers are not needed in this case, we already have sriov and jumbo_frame. jira-ticket: https://issues.redhat.com/browse/CNV-62769 Signed-off-by: Sergei Volkov <sevolkov@redhat.com> * [Chaos] Fix test_ceph_storage_outage timeout failure (RedHatQE#1208) In ODF 4.18, the csi-rbdplugin-provisioner Deployment managed RBD volume provisioning. In ODF 4.19, this component was replaced by openshift-storage.rbd.csi.ceph.com-ctrlplugin, \ which follows a standardized naming convention for CSI drivers. The new controller cannot be scaled down to 0 (it is immediately recreated by the Operator). This makes the previous testing approach (disabling the provisioner to simulate outages) no longer viable. To validate storage resilience, we now target other ODF components for disruption, such as: ceph-csi-controller-manager and odf-operator-controller-manager. Components like rook-ceph-operator, ocs-operator, and rook-ceph-osd are not retested here.\ (Their failure modes are already covered in test_migration.py). Signed-off-by: Qixuan Wang <qwang@redhat.com> * Storage: tests for storage migration of VM with hotplugged volume (RedHatQE#1160) * Storage: tests for storage migration of VM with hotplugged volume * address comments, add client, use ssh instead of console * Split test - verify hotplugged disk data * Fix fixture calls after test split * resolve conflicts * fix tox * use cluster arch * use resouece const * remove unused file * remove architecture leftovers * add centos support * add s390x marker on more tests * rename s390x fedora image name * address review comments * ause only one global_config * use only global config * fix leftovers in global configs * add missing check in tox * update how we extract latest instance type from os * update readme * fix instance type for arm * use const for windows * remove removed rhal versions * use X86_64 * add constants --------- Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> Signed-off-by: Roni Kishner<rkishner@redhat.com> Signed-off-by: Sergei Volkov <sevolkov@redhat.com> Signed-off-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Kirk Crane <kcrane@redhat.com> Co-authored-by: Nestor Acuna Blanco <37973744+nestoracunablanco@users.noreply.github.com> Co-authored-by: Ohad Revah <orevah@redhat.com> Co-authored-by: Roni Kishner <87259550+RoniKishner@users.noreply.github.com> Co-authored-by: Jose Manuel Castano <73908807+josemacassan@users.noreply.github.com> Co-authored-by: Sergei Volkov <153028767+servolkov@users.noreply.github.com> Co-authored-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

* Refactor arch s390x branch (RedHatQE#1199) * feat: refactor image architectures * fix versions and refactor functio location * get os from py_config only if exists * add missing file * fix tox and use global_config_x86.py * add todo on cirros s390x class * catch AttributeError it not set * catch AttributeError it not set * catch AttributeError it not set * update get_test_images_arch_class to upper * address comments and refactor archs * Move base images to data classes * add markers to pytest.ini * address comments * address review comments * add to tox * fix tox * update markers description * address comments * fix dataclasses * add OS_VERSION_STR to all * add docstrings * fix pre-commit * fix missing matrix flows * update gcp ini file * fix windows dir * fix dir assignment * update readme * re-add removed test * Replace hardcoded image size (RedHatQE#1207) * feat: mark some s390x compute tests as working (RedHatQE#1202) Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Update http server (RedHatQE#1222) * test: enable more tests for s390x (RedHatQE#1221) - test_vmi_annotations - test_deprecated_apis_in_audit_logs Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Fix TestVmiNetworkMetricsLinux tests flakiness (RedHatQE#1188) Fixing the tests that failed under TestVmiNetworkMetricsLinux. * Update test_vhostmd.py to use file based on architecture (RedHatQE#1170) Signed-off-by: Roni Kishner<rkishner@redhat.com> * Change RHEL Image name into test_import_http.py (RedHatQE#1215) * Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant * network tests: add hardware markers wherever there is special_infra (RedHatQE#1191) We strive to remove special_infra marker for all tests, this PR adds the use of available network hardware markers wherever there is a special_infra marker and guarantees an interchangeability. New markers are not needed in this case, we already have sriov and jumbo_frame. jira-ticket: https://issues.redhat.com/browse/CNV-62769 Signed-off-by: Sergei Volkov <sevolkov@redhat.com> * [Chaos] Fix test_ceph_storage_outage timeout failure (RedHatQE#1208) In ODF 4.18, the csi-rbdplugin-provisioner Deployment managed RBD volume provisioning. In ODF 4.19, this component was replaced by openshift-storage.rbd.csi.ceph.com-ctrlplugin, \ which follows a standardized naming convention for CSI drivers. The new controller cannot be scaled down to 0 (it is immediately recreated by the Operator). This makes the previous testing approach (disabling the provisioner to simulate outages) no longer viable. To validate storage resilience, we now target other ODF components for disruption, such as: ceph-csi-controller-manager and odf-operator-controller-manager. Components like rook-ceph-operator, ocs-operator, and rook-ceph-osd are not retested here.\ (Their failure modes are already covered in test_migration.py). Signed-off-by: Qixuan Wang <qwang@redhat.com> * Storage: tests for storage migration of VM with hotplugged volume (RedHatQE#1160) * Storage: tests for storage migration of VM with hotplugged volume * address comments, add client, use ssh instead of console * Split test - verify hotplugged disk data * Fix fixture calls after test split * resolve conflicts * fix tox * use cluster arch * use resouece const * remove unused file * remove architecture leftovers * add centos support * add s390x marker on more tests * rename s390x fedora image name * address review comments * ause only one global_config * use only global config * fix leftovers in global configs * add missing check in tox * update how we extract latest instance type from os * update readme * fix instance type for arm * use const for windows * remove removed rhal versions * use X86_64 * add constants --------- Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> Signed-off-by: Roni Kishner<rkishner@redhat.com> Signed-off-by: Sergei Volkov <sevolkov@redhat.com> Signed-off-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Kirk Crane <kcrane@redhat.com> Co-authored-by: Nestor Acuna Blanco <37973744+nestoracunablanco@users.noreply.github.com> Co-authored-by: Ohad Revah <orevah@redhat.com> Co-authored-by: Roni Kishner <87259550+RoniKishner@users.noreply.github.com> Co-authored-by: Jose Manuel Castano <73908807+josemacassan@users.noreply.github.com> Co-authored-by: Sergei Volkov <153028767+servolkov@users.noreply.github.com> Co-authored-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

* Refactor arch s390x branch (RedHatQE#1199) * feat: refactor image architectures * fix versions and refactor functio location * get os from py_config only if exists * add missing file * fix tox and use global_config_x86.py * add todo on cirros s390x class * catch AttributeError it not set * catch AttributeError it not set * catch AttributeError it not set * update get_test_images_arch_class to upper * address comments and refactor archs * Move base images to data classes * add markers to pytest.ini * address comments * address review comments * add to tox * fix tox * update markers description * address comments * fix dataclasses * add OS_VERSION_STR to all * add docstrings * fix pre-commit * fix missing matrix flows * update gcp ini file * fix windows dir * fix dir assignment * update readme * re-add removed test * Replace hardcoded image size (RedHatQE#1207) * feat: mark some s390x compute tests as working (RedHatQE#1202) Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Update http server (RedHatQE#1222) * test: enable more tests for s390x (RedHatQE#1221) - test_vmi_annotations - test_deprecated_apis_in_audit_logs Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Fix TestVmiNetworkMetricsLinux tests flakiness (RedHatQE#1188) Fixing the tests that failed under TestVmiNetworkMetricsLinux. * Update test_vhostmd.py to use file based on architecture (RedHatQE#1170) Signed-off-by: Roni Kishner<rkishner@redhat.com> * Change RHEL Image name into test_import_http.py (RedHatQE#1215) * Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant * network tests: add hardware markers wherever there is special_infra (RedHatQE#1191) We strive to remove special_infra marker for all tests, this PR adds the use of available network hardware markers wherever there is a special_infra marker and guarantees an interchangeability. New markers are not needed in this case, we already have sriov and jumbo_frame. jira-ticket: https://issues.redhat.com/browse/CNV-62769 Signed-off-by: Sergei Volkov <sevolkov@redhat.com> * [Chaos] Fix test_ceph_storage_outage timeout failure (RedHatQE#1208) In ODF 4.18, the csi-rbdplugin-provisioner Deployment managed RBD volume provisioning. In ODF 4.19, this component was replaced by openshift-storage.rbd.csi.ceph.com-ctrlplugin, \ which follows a standardized naming convention for CSI drivers. The new controller cannot be scaled down to 0 (it is immediately recreated by the Operator). This makes the previous testing approach (disabling the provisioner to simulate outages) no longer viable. To validate storage resilience, we now target other ODF components for disruption, such as: ceph-csi-controller-manager and odf-operator-controller-manager. Components like rook-ceph-operator, ocs-operator, and rook-ceph-osd are not retested here.\ (Their failure modes are already covered in test_migration.py). Signed-off-by: Qixuan Wang <qwang@redhat.com> * Storage: tests for storage migration of VM with hotplugged volume (RedHatQE#1160) * Storage: tests for storage migration of VM with hotplugged volume * address comments, add client, use ssh instead of console * Split test - verify hotplugged disk data * Fix fixture calls after test split * resolve conflicts * fix tox * use cluster arch * use resouece const * remove unused file * remove architecture leftovers * add centos support * add s390x marker on more tests * rename s390x fedora image name * address review comments * ause only one global_config * use only global config * fix leftovers in global configs * add missing check in tox * update how we extract latest instance type from os * update readme * fix instance type for arm * use const for windows * remove removed rhal versions * use X86_64 * add constants --------- Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> Signed-off-by: Roni Kishner<rkishner@redhat.com> Signed-off-by: Sergei Volkov <sevolkov@redhat.com> Signed-off-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Kirk Crane <kcrane@redhat.com> Co-authored-by: Nestor Acuna Blanco <37973744+nestoracunablanco@users.noreply.github.com> Co-authored-by: Ohad Revah <orevah@redhat.com> Co-authored-by: Roni Kishner <87259550+RoniKishner@users.noreply.github.com> Co-authored-by: Jose Manuel Castano <73908807+josemacassan@users.noreply.github.com> Co-authored-by: Sergei Volkov <153028767+servolkov@users.noreply.github.com> Co-authored-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

* Refactor arch s390x branch (RedHatQE#1199) * feat: refactor image architectures * fix versions and refactor functio location * get os from py_config only if exists * add missing file * fix tox and use global_config_x86.py * add todo on cirros s390x class * catch AttributeError it not set * catch AttributeError it not set * catch AttributeError it not set * update get_test_images_arch_class to upper * address comments and refactor archs * Move base images to data classes * add markers to pytest.ini * address comments * address review comments * add to tox * fix tox * update markers description * address comments * fix dataclasses * add OS_VERSION_STR to all * add docstrings * fix pre-commit * fix missing matrix flows * update gcp ini file * fix windows dir * fix dir assignment * update readme * re-add removed test * Replace hardcoded image size (RedHatQE#1207) * feat: mark some s390x compute tests as working (RedHatQE#1202) Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Update http server (RedHatQE#1222) * test: enable more tests for s390x (RedHatQE#1221) - test_vmi_annotations - test_deprecated_apis_in_audit_logs Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> * Fix TestVmiNetworkMetricsLinux tests flakiness (RedHatQE#1188) Fixing the tests that failed under TestVmiNetworkMetricsLinux. * Update test_vhostmd.py to use file based on architecture (RedHatQE#1170) Signed-off-by: Roni Kishner<rkishner@redhat.com> * Change RHEL Image name into test_import_http.py (RedHatQE#1215) * Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant * network tests: add hardware markers wherever there is special_infra (RedHatQE#1191) We strive to remove special_infra marker for all tests, this PR adds the use of available network hardware markers wherever there is a special_infra marker and guarantees an interchangeability. New markers are not needed in this case, we already have sriov and jumbo_frame. jira-ticket: https://issues.redhat.com/browse/CNV-62769 Signed-off-by: Sergei Volkov <sevolkov@redhat.com> * [Chaos] Fix test_ceph_storage_outage timeout failure (RedHatQE#1208) In ODF 4.18, the csi-rbdplugin-provisioner Deployment managed RBD volume provisioning. In ODF 4.19, this component was replaced by openshift-storage.rbd.csi.ceph.com-ctrlplugin, \ which follows a standardized naming convention for CSI drivers. The new controller cannot be scaled down to 0 (it is immediately recreated by the Operator). This makes the previous testing approach (disabling the provisioner to simulate outages) no longer viable. To validate storage resilience, we now target other ODF components for disruption, such as: ceph-csi-controller-manager and odf-operator-controller-manager. Components like rook-ceph-operator, ocs-operator, and rook-ceph-osd are not retested here.\ (Their failure modes are already covered in test_migration.py). Signed-off-by: Qixuan Wang <qwang@redhat.com> * Storage: tests for storage migration of VM with hotplugged volume (RedHatQE#1160) * Storage: tests for storage migration of VM with hotplugged volume * address comments, add client, use ssh instead of console * Split test - verify hotplugged disk data * Fix fixture calls after test split * resolve conflicts * fix tox * use cluster arch * use resouece const * remove unused file * remove architecture leftovers * add centos support * add s390x marker on more tests * rename s390x fedora image name * address review comments * ause only one global_config * use only global config * fix leftovers in global configs * add missing check in tox * update how we extract latest instance type from os * update readme * fix instance type for arm * use const for windows * remove removed rhal versions * use X86_64 * add constants --------- Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com> Signed-off-by: Roni Kishner<rkishner@redhat.com> Signed-off-by: Sergei Volkov <sevolkov@redhat.com> Signed-off-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Kirk Crane <kcrane@redhat.com> Co-authored-by: Nestor Acuna Blanco <37973744+nestoracunablanco@users.noreply.github.com> Co-authored-by: Ohad Revah <orevah@redhat.com> Co-authored-by: Roni Kishner <87259550+RoniKishner@users.noreply.github.com> Co-authored-by: Jose Manuel Castano <73908807+josemacassan@users.noreply.github.com> Co-authored-by: Sergei Volkov <153028767+servolkov@users.noreply.github.com> Co-authored-by: Qixuan Wang <qwang@redhat.com> Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>

Change RHEL Image name into test_import_http.py

2952492

openshift-virtualization-qe-bot assigned josemacassan Jun 16, 2025

openshift-virtualization-qe-bot requested a review from duyanyan June 16, 2025 09:49

openshift-virtualization-qe-bot mentioned this pull request Jun 16, 2025

Change RHEL Image name into test_import_http.py - 1215 #1216

Closed

openshift-virtualization-qe-bot requested a review from jpeimer June 16, 2025 09:49

openshift-virtualization-qe-bot added branch-main size/XS labels Jun 16, 2025

openshift-virtualization-qe-bot previously approved these changes Jun 16, 2025

View reviewed changes

openshift-virtualization-qe-bot-2 added the lgtm-openshift-virtualization-qe-bot label Jun 16, 2025

Fix naming into image.

be49196

josemacassan dismissed openshift-virtualization-qe-bot’s stale review via be49196 June 16, 2025 12:08

openshift-virtualization-qe-bot-3 removed the lgtm-openshift-virtualization-qe-bot label Jun 16, 2025

openshift-virtualization-qe-bot added tox:verify-bugs-are-open:passed D/S Testing and removed tox:verify-bugs-are-open:running D/S Testing labels Jun 17, 2025

openshift-virtualization-qe-bot approved these changes Jun 17, 2025

View reviewed changes

openshift-virtualization-qe-bot-2 added the lgtm-openshift-virtualization-qe-bot label Jun 17, 2025

openshift-virtualization-qe-bot-3 added approved-jpeimer lgtm-jpeimer labels Jun 17, 2025

RoniKishner approved these changes Jun 17, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-RoniKishner label Jun 17, 2025

rnetser enabled auto-merge (squash) June 17, 2025 09:05

openshift-virtualization-qe-bot added approved-rnetser lgtm-rnetser labels Jun 17, 2025

openshift-virtualization-qe-bot-2 added the can-be-merged label Jun 17, 2025

rnetser disabled auto-merge June 17, 2025 09:07

rnetser merged commit 13c8e0f into RedHatQE:main Jun 17, 2025
8 checks passed

rnetser pushed a commit to rnetser/openshift-virtualization-tests that referenced this pull request Jun 19, 2025

Change RHEL Image name into test_import_http.py (RedHatQE#1215)

53f72b5

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

servolkov pushed a commit to servolkov/openshift-virtualization-tests that referenced this pull request Aug 13, 2025

Change RHEL Image name into test_import_http.py (RedHatQE#1215)

b414488

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

servolkov pushed a commit to servolkov/openshift-virtualization-tests that referenced this pull request Aug 13, 2025

Change RHEL Image name into test_import_http.py (RedHatQE#1215)

08e3f3a

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

rlobillo pushed a commit to rlobillo/openshift-virtualization-tests that referenced this pull request Feb 4, 2026

Change RHEL Image name into test_import_http.py (RedHatQE#1215)

f76a5be

* Change RHEL Image name into test_import_http.py * Fix naming into image. * Remove unused RHEL constant

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change RHEL Image name into test_import_http.py#1215

Change RHEL Image name into test_import_http.py#1215
rnetser merged 3 commits intoRedHatQE:mainfrom
josemacassan:update_rhel8_name

josemacassan commented Jun 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

openshift-virtualization-qe-bot commented Jun 16, 2025

Uh oh!

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

josemacassan commented Jun 16, 2025

Uh oh!

jpeimer commented Jun 17, 2025

Uh oh!

rnetser commented Jun 17, 2025

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 17, 2025

Uh oh!

josemacassan commented Jun 17, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

josemacassan commented Jun 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Uh oh!

openshift-virtualization-qe-bot commented Jun 16, 2025

Uh oh!

coderabbitai bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

josemacassan commented Jun 16, 2025

Uh oh!

jpeimer commented Jun 17, 2025

Uh oh!

rnetser commented Jun 17, 2025

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 17, 2025

Uh oh!

josemacassan commented Jun 17, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

josemacassan commented Jun 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)