Skip to content

Refactor disk-uploader task tests #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

geetikakay
Copy link
Contributor

  • Add support for export-source-kind PVC
  • Refactor code to support Datasource with snapshot
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

@ghost
Copy link

ghost commented Feb 24, 2025

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

Copy link
Collaborator

@polarion-jenkins polarion-jenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D/S test tox -e verify-bugs-are-open passed: cnv-tests-tox-executor/7126

- Add support for export-source-kind PVC
- Refactor code to support Datasource with snapshot

Signed-off-by: Geetika Kapoor <[email protected]>
@geetikakay
Copy link
Contributor Author

/verified

@ghost ghost added the approved-vsibirsk label Mar 19, 2025
@vsibirsk vsibirsk merged commit 13ad8f0 into RedHatQE:main Mar 19, 2025
7 checks passed
@ghost
Copy link

ghost commented Mar 19, 2025

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-313.

@ghost
Copy link

ghost commented Mar 19, 2025

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

Anatw pushed a commit to Anatw/openshift-virtualization-tests that referenced this pull request Apr 1, 2025
- Add support for export-source-kind PVC
- Refactor code to support Datasource with snapshot

Signed-off-by: Geetika Kapoor <[email protected]>
@geetikakay
Copy link
Contributor Author

/cherry-pick cnv-4.18

@ghost
Copy link

ghost commented May 13, 2025

Manual cherry-pick is needed
Cherry pick failed for 13ad8f0 to cnv-4.18:
To cherry-pick run:

git remote update
git checkout cnv-4.18
git pull origin cnv-4.18
git checkout -b disk_uploader-cnv-4.18
git cherry-pick 13ad8f06cece62f5ef714aef27338cee7a989a8c
git push origin disk_uploader-cnv-4.18

geetikakay added a commit to geetikakay/openshift-virtualization-tests that referenced this pull request May 13, 2025
- Add support for export-source-kind PVC
- Refactor code to support Datasource with snapshot

Signed-off-by: Geetika Kapoor <[email protected]>
geetikakay added a commit to geetikakay/openshift-virtualization-tests that referenced this pull request May 15, 2025
- Add support for export-source-kind PVC
- Refactor code to support Datasource with snapshot

Signed-off-by: Geetika Kapoor <[email protected]>
geetikakay added a commit to geetikakay/openshift-virtualization-tests that referenced this pull request May 19, 2025
- Add support for export-source-kind PVC
- Refactor code to support Datasource with snapshot

Signed-off-by: Geetika Kapoor <[email protected]>
rnetser pushed a commit that referenced this pull request May 20, 2025
- Add support for export-source-kind PVC
- Refactor code to support Datasource with snapshot

Signed-off-by: Geetika Kapoor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants