Add logger.warning guideline to CLAUDE.md #3528

hmeir · 2026-01-20T07:00:58Z

Short description:

We are using warning level logs,
for cases like conditional/temp skips or workarounds. for example bugs.

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

coderabbitai · 2026-01-20T07:01:06Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

CLAUDE.md is excluded by !**/*.md

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-virtualization-qe-bot-3 · 2026-01-20T07:01:25Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open (optional)
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No WIP, hold, conflict labels
Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

RoniKishner
dshchedr
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is automatically removed on each new commit
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

coderabbitai · 2026-01-20T08:03:09Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

rlobillo · 2026-01-20T10:44:45Z

/lgtm

We are using warning level logs, for cases like conditional/temp skips or workarounds. for example bugs. Signed-off-by: Harel Meir <hmeir@redhat.com>

dshchedr · 2026-01-20T21:07:19Z

CLAUDE.md

+  - `LOGGER.info(f"VM created", extra={"name": vm_name, "namespace": ns})`
+  - `LOGGER.warning(f"Skipping CRD due to known issue", extra={"crd_name": crd.name, "jira_id": jira_id})`


why we advice to set extra if we don't print it in our logger message?
https://github.com/RedHatQE/openshift-virtualization-tests/blob/main/utilities/logger.py#L53

this needs to be changed; following an offline discusstion -please update

coderabbitai bot previously approved these changes Jan 20, 2026

View reviewed changes

openshift-virtualization-qe-bot-3 requested a review from RoniKishner January 20, 2026 07:01

openshift-virtualization-qe-bot-3 assigned hmeir Jan 20, 2026

openshift-virtualization-qe-bot-3 mentioned this pull request Jan 20, 2026

Add logger.warning guideline to CLAUDE.md - 3528 #3529

Open

openshift-virtualization-qe-bot-3 requested a review from rnetser January 20, 2026 07:01

openshift-virtualization-qe-bot-3 added the branch-main label Jan 20, 2026

openshift-virtualization-qe-bot-3 requested a review from dshchedr January 20, 2026 07:01

openshift-virtualization-qe-bot-3 added the size/XS label Jan 20, 2026

openshift-virtualization-qe-bot-3 requested a review from vsibirsk January 20, 2026 07:01

hmeir dismissed coderabbitai[bot]’s stale review via d39ae86 January 20, 2026 07:01

hmeir force-pushed the add-warnings-log-to-claude-md branch from 386fe1b to d39ae86 Compare January 20, 2026 07:01

coderabbitai bot previously approved these changes Jan 20, 2026

View reviewed changes

openshift-virtualization-qe-bot previously approved these changes Jan 20, 2026

View reviewed changes

hmeir mentioned this pull request Jan 20, 2026

[IUO] Skip unreadable backup tracker CRDs if CNV-76369 is open #3526

Merged

openshift-virtualization-qe-bot added the needs-rebase label Jan 20, 2026

openshift-virtualization-qe-bot added the lgtm-rlobillo label Jan 20, 2026

Add logger.warning guideline to CLAUDE.md

cf55523

We are using warning level logs, for cases like conditional/temp skips or workarounds. for example bugs. Signed-off-by: Harel Meir <hmeir@redhat.com>

hmeir dismissed stale reviews from openshift-virtualization-qe-bot and coderabbitai[bot] via cf55523 January 20, 2026 13:06

hmeir force-pushed the add-warnings-log-to-claude-md branch from d39ae86 to cf55523 Compare January 20, 2026 13:06

coderabbitai bot approved these changes Jan 20, 2026

View reviewed changes

openshift-virtualization-qe-bot-3 removed verified lgtm-openshift-virtualization-qe-bot labels Jan 20, 2026

openshift-virtualization-qe-bot removed the tox:verify-tc-requirement-polarion:passed D/S Testing label Jan 20, 2026

openshift-virtualization-qe-bot-3 removed lgtm-rlobillo lgtm-coderabbitai[bot] labels Jan 20, 2026

openshift-virtualization-qe-bot added the tox:verify-tc-requirement-polarion:running D/S Testing label Jan 20, 2026

openshift-virtualization-qe-bot-3 removed the needs-rebase label Jan 20, 2026

openshift-virtualization-qe-bot approved these changes Jan 20, 2026

View reviewed changes

openshift-virtualization-qe-bot-5 added the lgtm-openshift-virtualization-qe-bot label Jan 20, 2026

openshift-virtualization-qe-bot-2 added the lgtm-coderabbitai[bot] label Jan 20, 2026

openshift-virtualization-qe-bot-3 added the needs-rebase label Jan 20, 2026

dshchedr requested changes Jan 20, 2026

View reviewed changes

openshift-virtualization-qe-bot-3 added the changes-requested-dshchedr label Jan 20, 2026

openshift-virtualization-qe-bot-5 added the commented-rnetser label Jan 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add logger.warning guideline to CLAUDE.md #3528

Add logger.warning guideline to CLAUDE.md #3528

Uh oh!

hmeir commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

Review skipped

Uh oh!

openshift-virtualization-qe-bot-3 commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026

Uh oh!

rlobillo commented Jan 20, 2026

Uh oh!

dshchedr Jan 20, 2026

Uh oh!

rnetser Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

		- `LOGGER.info(f"VM created", extra={"name": vm_name, "namespace": ns})`
		- `LOGGER.warning(f"Skipping CRD due to known issue", extra={"crd_name": crd.name, "jira_id": jira_id})`

Add logger.warning guideline to CLAUDE.md #3528

Are you sure you want to change the base?

Add logger.warning guideline to CLAUDE.md #3528

Uh oh!

Conversation

hmeir commented Jan 20, 2026

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-virtualization-qe-bot-3 commented Jan 20, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

coderabbitai bot commented Jan 20, 2026

Uh oh!

rlobillo commented Jan 20, 2026

Uh oh!

dshchedr Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

rnetser Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coderabbitai bot commented Jan 20, 2026 •

edited

Loading