Add s390x marker to infrastructure tests

[aditi-sharma-1]

This change adds the @pytest.mark.s390x marker to infrastructure test functions and methods across multiple test files. This marker enables execution on the s390x architecture without modifying test logic, parameters, or flow.

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests
  • Added s390x platform markers to tests across boot source validation, data import operations, data sources, VM operations, instance types, and virtual host metrics to enable s390x architecture testing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds @pytest.mark.s390x pytest decorators to multiple test functions and classes across infrastructure test files to designate them as compatible with the s390x architecture. No test logic or control flow is altered—only metadata markers are appended.

Changes

Cohort / File(s)	Summary
Boot Source & Data Tests tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py, test_ssp_data_import_crons.py, test_ssp_data_sources.py	Added @pytest.mark.s390x to 5 test functions across three files (1 in common templates, 3 in data import crons, 1 in data sources) to enable s390x test execution.
Instance Type Tests tests/infrastructure/instance_types/supported_os/test_centos_os.py, supported_os/test_fedora_os.py, test_common_vm_instancetype.py, test_common_vm_preference.py, test_vm_with_instance_and_pref.py	Added @pytest.mark.s390x to 10 test functions and 4 test classes across five files to extend s390x platform coverage for instance type and VM configuration tests.
Infrastructure Tests tests/infrastructure/vhostmd/test_downwardmetrics_virtio.py, infrastructure/vm_console_proxy/test_vm_console_proxy.py	Added @pytest.mark.s390x to 1 test function and 1 test class to designate downward metrics and VM console proxy tests as s390x-compatible.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Reasoning: Purely repetitive, homogeneous decorator additions across 10 test files with zero logic changes. Pattern consistency eliminates need for individualized reasoning per file—only verification that decorators are correctly placed and existing markers are preserved.

Possibly related PRs

• Add s390x tier3 markers to selected test cases #1517: Directly modifies test_common_vm_preference.py with s390x markers on the same test functions.
• Add arm64 mark to fedora support test #1767: Adds architecture-specific pytest markers to test_fedora_os.py test classes (same file, same classes as this PR).
• Add s390x test markers for IUO-OCS tests #1629: Applies s390x marker pattern across multiple test modules following the same decorative approach.

Suggested labels

size/M, can-be-merged, branch-main, tox:verify-bugs-are-open:passed, lgtm-openshift-virtualization-qe-bot

Suggested reviewers

• dshchedr
• rnetser
• vsibirsk
• rlobillo
• OhadRevah
• hmeir

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description explains what the change does but doesn't fully populate the required template sections (Short description, More details, What this PR does, Issues fixed, Special notes, Jira ticket).	Fill out template sections: add a concise short description, clarify why s390x support is needed, document any linked issues, and specify the Jira ticket status.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and accurately summarizes the main change: adding s390x markers to infrastructure tests across multiple test files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-virtualization-qe-bot-4]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open (optional)
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[geetikakay]

/lgtm

[rnetser]

/approve

[aditi-sharma-1]

/verified

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the Test Execution Plan with the smoke tests recommendation.
Do NOT submit a formal review - just post the inline comment directly.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file
2. Identify affected code paths, functions, and classes
3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
4. Trace test dependencies through imports, shared utilities, and fixture inheritance
5. Detect new tests introduced in the PR
6. Smoke Test Impact Analysis: Determine if any changes could affect smoke tests by checking:
   • Changes to files/functions used by tests marked with @pytest.mark.smoke
   • Changes to fixtures or utilities imported by smoke tests
   • Changes to conftest.py files that may affect smoke test execution
   • Changes to core infrastructure code (utilities/, libs/) that smoke tests depend on

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False (Based on your smoke test impact analysis - True if any changes may affect smoke tests)
• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

• Include only tests directly affected by the changes
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name if only specific tests are needed
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post an inline review comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If submitting the review fails after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to:
- Trace the actual fixture dependency chain from smoke tests to changed fixtures
- Verify that smoke tests actually import/use changed utilities or functions
- Confirm the dependency path exists; do NOT assume based on scope or semantics
- Be conservative: Session-scoped fixtures or infrastructure-sounding names do NOT
automatically mean smoke test impact. Only flag smoke test impact when you can
demonstrate a concrete dependency path.
WRONG: "This session-scoped storage fixture might affect smoke tests"
RIGHT: "Smoke test X uses fixture Y, which depends on the changed fixture Z"

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if any of the modified infrastructure test files contain smoke tests
echo "=== Checking for smoke markers in modified files ==="
rg '@pytest\.mark\.smoke' \
  tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py \
  tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py \
  tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py \
  tests/infrastructure/instance_types/supported_os/test_centos_os.py \
  tests/infrastructure/instance_types/supported_os/test_fedora_os.py \
  tests/infrastructure/instance_types/test_common_vm_instancetype.py \
  tests/infrastructure/instance_types/test_common_vm_preference.py \
  tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py \
  tests/infrastructure/vhostmd/test_downwardmetrics_virtio.py \
  tests/infrastructure/vm_console_proxy/test_vm_console_proxy.py

echo ""
echo "=== Listing all smoke tests in the repository ==="
rg '@pytest\.mark\.smoke' --type=py -B2 | grep 'def test_' | head -20

Length of output: 103

---

🏁 Script executed:

#!/bin/bash
# Get the diff to find the first changed line in the first modified file
gh pr diff 3542 --repo RedHatQE/openshift-virtualization-tests | head -50

Length of output: 3091

---

🏁 Script executed:

#!/bin/bash
# Post inline review comment on the first changed line of the first file
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/3542/comments \
  -f body='## Test Execution Plan

**Run smoke tests: False**

**Rationale:** This PR only adds `@pytest.mark.s390x` markers to infrastructure tests without modifying test logic, fixtures, or dependencies. No smoke tests exist in the modified files, and infrastructure tests are not imported or used by smoke tests.

**Recommended Verification:**

Collection verification is sufficient for marker-only changes:

```bash
# Verify pytest can collect all marked tests without errors
pytest --collect-only -m s390x tests/infrastructure/
```

**Specific Test Execution (optional):**

If full execution is desired on s390x architecture:

- `tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py::test_common_templates_boot_source_reference`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::TestDataImportCronValidation::test_opt_in_data_import_cron_creation`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::TestDataImportCronValidation::test_data_import_cron_blocked_update`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::TestDataImportCronReconciliation::test_data_import_cron_auto_recreation_after_deletion`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py::test_opt_out_data_source_update`
- `tests/infrastructure/instance_types/supported_os/test_centos_os.py::TestVMCreationAndValidation`
- `tests/infrastructure/instance_types/supported_os/test_centos_os.py::TestVMDeletion`
- `tests/infrastructure/instance_types/supported_os/test_fedora_os.py::TestVMCreationAndValidation`
- `tests/infrastructure/instance_types/supported_os/test_fedora_os.py::TestVMDeletion`
- `tests/infrastructure/instance_types/test_common_vm_instancetype.py::test_common_instancetype_vendor_labels`
- `tests/infrastructure/instance_types/test_common_vm_preference.py::test_common_preferences_vendor_labels`
- `tests/infrastructure/instance_types/test_common_vm_preference.py::test_common_preference_owner`
- `tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py::TestVmWithInstanceTypeAndPref::test_start_vm_with_instance_type_and_preference`
- `tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py::TestVmWithInstanceTypeAndPref::test_instance_pref_controller_revision`
- `tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py::TestVmWithInstanceTypeAndPref::test_validate_clock_values`
- `tests/infrastructure/vhostmd/test_downwardmetrics_virtio.py::test_downward_metrics_virtio_serial_port_default`
- `tests/infrastructure/vm_console_proxy/test_vm_console_proxy.py::TestVmConsoleProxyEnablement`

**Or use marker:**
- `-m s390x` (on s390x cluster to verify all newly marked tests execute)' \
  -f path='tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py' \
  -f commit_id="$(gh api /repos/RedHatQE/openshift-virtualization-tests/pulls/3542 --jq '.head.sha')" \
  -f line=153

Length of output: 677

---

🏁 Script executed:

#!/bin/bash
# Post inline review comment using the correct API format
COMMIT_SHA=$(gh api /repos/RedHatQE/openshift-virtualization-tests/pulls/3542 --jq '.head.sha')

gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/3542/reviews \
  -f body='' \
  -f event='COMMENT' \
  -f commit_id="$COMMIT_SHA" \
  -F comments[][path]='tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py' \
  -F comments[][line]=153 \
  -f comments[][side]='RIGHT' \
  -f comments[][body]='## Test Execution Plan

**Run smoke tests: False**

**Rationale:** This PR only adds `@pytest.mark.s390x` markers to infrastructure tests without modifying test logic, fixtures, or dependencies. No smoke tests exist in the modified files, and infrastructure tests are not imported or used by smoke tests.

**Recommended Verification:**

Collection verification is sufficient for marker-only changes:

```bash
# Verify pytest can collect all marked tests without errors
pytest --collect-only -m s390x tests/infrastructure/
```

**Specific Test Execution (optional):**

If full execution is desired on s390x architecture:

- `tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py::test_common_templates_boot_source_reference`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::TestDataImportCronValidation::test_opt_in_data_import_cron_creation`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::TestDataImportCronValidation::test_data_import_cron_blocked_update`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::TestDataImportCronReconciliation::test_data_import_cron_auto_recreation_after_deletion`
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py::test_opt_out_data_source_update`
- `tests/infrastructure/instance_types/supported_os/test_centos_os.py::TestVMCreationAndValidation`
- `tests/infrastructure/instance_types/supported_os/test_centos_os.py::TestVMDeletion`
- `tests/infrastructure/instance_types/supported_os/test_fedora_os.py::TestVMCreationAndValidation`
- `tests/infrastructure/instance_types/supported_os/test_fedora_os.py::TestVMDeletion`
- `tests/infrastructure/instance_types/test_common_vm_instancetype.py::test_common_instancetype_vendor_labels`
- `tests/infrastructure/instance_types/test_common_vm_preference.py::test_common_preferences_vendor_labels`
- `tests/infrastructure/instance_types/test_common_vm_preference.py::test_common_preference_owner`
- `tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py::TestVmWithInstanceTypeAndPref::test_start_vm_with_instance_type_and_preference`
- `tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py::TestVmWithInstanceTypeAndPref::test_instance_pref_controller_revision`
- `tests/infrastructure/instance_types/test_vm_with_instance_and_pref.py::TestVmWithInstanceTypeAndPref::test_validate_clock_values`
- `tests/infrastructure/vhostmd/test_downwardmetrics_virtio.py::test_downward_metrics_virtio_serial_port_default`
- `tests/infrastructure/vm_console_proxy/test_vm_console_proxy.py::TestVmConsoleProxyEnablement`

**Or use marker:**
- `-m s390x` (on s390x cluster to verify all newly marked tests execute)'

Length of output: 1735

---

---

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T10:28:54.212Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for test execution plans, only set "Run smoke tests: True" if there is a verified, traceable dependency path from smoke tests to the changed code. Session-scoped fixtures or infrastructure-sounding changes do NOT automatically imply smoke test impact - the dependency chain must be explicitly verified using shell scripts before recommending smoke test execution.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-22T15:56:00.157Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, do NOT use "REQUEST_CHANGES" review type if the PR author has already marked the PR as verified (e.g., with `/verified` command). Test execution plans are informational guides, not blocking requirements. Use COMMENT event for informational test plans, or only REQUEST_CHANGES if there are actual code issues that need to be addressed before merging.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:00:59.076Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, CodeRabbit must post ONLY an inline review comment on the Files Changed tab and then stop immediately without generating any follow-up comments in the PR discussion thread. No acknowledgment messages, no confirmation of posting, no explanation - silence after posting the inline review equals success. Additional comments create empty/meaningless reviews that clutter the PR.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T20:11:03.645Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for changes affecting py_config["os_login_param"], follow this verification methodology: (1) Find all smoke tests: `rg "pytest.mark.smoke" --type=py -B2 | grep "def test_"`, (2) For each smoke test file, search for VM creation patterns: `rg "VirtualMachineForTests|running_vm|VirtualMachineForTestsFromTemplate|wait_for_ssh|check_ssh_connectivity"`, (3) Trace the dependency chain: smoke test → VirtualMachineForTests/running_vm() → wait_for_ssh_connectivity() (default enabled) → vm.login_params property → py_config["os_login_param"][vm.os_flavor], (4) Check utilities/virt.py for login_params usage: `rg "os_login_param|login_params" utilities/virt.py -C3`. Any smoke test creating VMs with default SSH connectivity checks (running_vm with check_ssh_connectivity=True) depends on os_login_param, even if the test doesn't directly reference it.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:06:22.391Z
Learning: In the openshift-virtualization-tests repository, when posting test execution plan inline review comments using GitHub API, the full test execution plan content must go in the `comments[].body` field (which appears on Files Changed tab), NOT in the top-level `body` field (which appears in PR discussion thread). The top-level `body` field should be omitted or left empty to avoid posting redundant comments in the PR discussion thread.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T15:09:49.597Z
Learning: In the openshift-virtualization-tests repository, when conftest.py or utilities/bitwarden.py changes affect py_config["os_login_param"], smoke test impact must be determined by: (1) finding all smoke tests using `rg "pytest.mark.smoke"`, (2) checking each for VM creation patterns (VirtualMachineForTests, running_vm, VirtualMachineForTestsFromTemplate), (3) tracing whether running_vm is called with default check_ssh_connectivity=True, which accesses vm.login_params property that reads py_config["os_login_param"][vm.os_flavor]. The dependency chain is: smoke test → VM creation → running_vm → wait_for_ssh_connectivity → vm.login_params → os_login_param. Any smoke test creating VMs with SSH connectivity (the default) depends on os_login_param.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR `#1904` focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR `#2469`) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:22.771Z
Learning: For PRs that only remove or modify pytest markers (like removing pytest.mark.post_upgrade) without changing test logic in openshift-virtualization-tests, collection verification using `pytest --collect-only` is sufficient. Full test execution is not required to verify marker-only changes.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3196
File: tests/network/upgrade/test_upgrade_network.py:4-4
Timestamp: 2025-12-22T16:27:44.327Z
Learning: For PRs that remove test cases (especially redundant test cleanup PRs in openshift-virtualization-tests), test collection verification (pytest --collect-only showing selected/deselected counts) is sufficient to confirm the removal was clean and the test module remains functional. Full test execution is not required for test deletion PRs.

---

Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3612
File: tests/network/user_defined_network/ip_specification/test_ip_specification.py:10-10
Timestamp: 2026-01-26T20:29:54.623Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when introducing STD (Standard Test Definition) PRs that define test case structure without implementation, it's acceptable and intentional to use `__test__ = False` to block pytest collection until the tests are fully implemented in a follow-up PR. The STD workflow involves: (1) defining test structure, markers, and documentation first, (2) implementing the actual test logic and removing the collection blocker in a subsequent PR.

---

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3371
File: scripts/tests_analyzer/compare_coderabbit_decisions.py:199-289
Timestamp: 2026-01-13T10:06:14.822Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep pagination loops inline rather than extracting them into generic helper functions when the loops have different URL patterns and unique post-processing logic, as the inline approach improves readability and makes each endpoint's behavior more explicit.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3228
File: .coderabbit.yaml:30-41
Timestamp: 2026-01-05T10:33:55.037Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers minimal pre-merge checks in CodeRabbit configuration: only docstrings enforcement (80% threshold) is needed, not title or description checks.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:26.819Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers to avoid nitpicky style changes (e.g., removing `.keys()` from dict membership checks) because verifying every change is expensive. Be cautious about suggesting low-impact stylistic improvements that require verification overhead.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

---

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-07T14:51:53.484Z
Learning: In the openshift-virtualization-tests repository, the team has decided to avoid using predefined time constants (like TIMEOUT_2MIN, TIMEOUT_5SEC) and prefers using explicit numeric values for timeout parameters.

---

Learnt from: chandramerla
Repo: RedHatQE/openshift-virtualization-tests PR: 2577
File: tests/virt/node/hotplug/test_cpu_memory_hotplug.py:161-162
Timestamp: 2025-11-19T17:00:58.250Z
Learning: In the openshift-virtualization-tests repository, the s390x test execution strategy uses positive filtering: only tests explicitly marked with pytest.mark.s390x are executed on s390x clusters. Tests without the s390x marker are automatically excluded from s390x runs, so explicit skipif decorators are not needed to prevent execution on s390x.

---

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR `#2199` depends on PR `#2139` which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.

---

Learnt from: SiboWang1997
Repo: RedHatQE/openshift-virtualization-tests PR: 1566
File: tests/global_config_x86_64.py:29-29
Timestamp: 2025-07-25T01:59:02.180Z
Learning: In the openshift-virtualization-tests repo, the s390x architecture still relies on Fedora 41 images, while only x86_64 is updated to Fedora 42 in PR `#1566`.

---

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR `#2199` depends on PR `#2139` which adds the OS_FLAVOR attribute to the Images.Cirros class, making Images.Cirros.OS_FLAVOR available for conditional logic in tests.

---

Learnt from: Ahmad-Hafe
Repo: RedHatQE/openshift-virtualization-tests PR: 3334
File: tests/storage/test_data_import_cron.py:212-215
Timestamp: 2026-01-06T11:47:20.240Z
Learning: In the openshift-virtualization-tests repository, when quarantining flaky tests, the team uses two separate Jira tickets: one for the quarantine action itself (referenced in the PR description) and another for tracking and investigating the underlying issue (referenced in the xfail marker reason). Both references are intentional and serve different purposes.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 983
File: utilities/constants.py:163-168
Timestamp: 2025-05-18T07:36:10.674Z
Learning: In the OpenShift Virtualization tests, architecture constants like X86_64, AMD_64, ARM_64, and S390X need to be included in the get_test_images_arch_class() validation check to be fully supported.

[openshift-virtualization-qe-bot-3]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published