Skip to content

Conversation

@aditi-sharma-1
Copy link
Contributor

@aditi-sharma-1 aditi-sharma-1 commented Jan 20, 2026

This change adds the @pytest.mark.s390x marker to infrastructure test functions and methods across multiple test files. This marker enables execution on the s390x architecture without modifying test logic, parameters, or flow.

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

Summary by CodeRabbit

  • Tests
    • Added s390x platform markers to tests across boot source validation, data import operations, data sources, VM operations, instance types, and virtual host metrics to enable s390x architecture testing.

✏️ Tip: You can customize this high-level summary in your review settings.

This change adds the @pytest.mark.s390x marker to infrastructure test functions and methods across multiple test files. This marker enables execution on the s390x architecture without modifying test logic, parameters, or flow.

Signed-off-by: Aditi Sharma <Aditi.Sharma@ibm.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

This PR adds @pytest.mark.s390x pytest decorators to multiple test functions and classes across infrastructure test files to designate them as compatible with the s390x architecture. No test logic or control flow is altered—only metadata markers are appended.

Changes

Cohort / File(s) Summary
Boot Source & Data Tests
tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py, test_ssp_data_import_crons.py, test_ssp_data_sources.py
Added @pytest.mark.s390x to 5 test functions across three files (1 in common templates, 3 in data import crons, 1 in data sources) to enable s390x test execution.
Instance Type Tests
tests/infrastructure/instance_types/supported_os/test_centos_os.py, supported_os/test_fedora_os.py, test_common_vm_instancetype.py, test_common_vm_preference.py, test_vm_with_instance_and_pref.py
Added @pytest.mark.s390x to 10 test functions and 4 test classes across five files to extend s390x platform coverage for instance type and VM configuration tests.
Infrastructure Tests
tests/infrastructure/vhostmd/test_downwardmetrics_virtio.py, infrastructure/vm_console_proxy/test_vm_console_proxy.py
Added @pytest.mark.s390x to 1 test function and 1 test class to designate downward metrics and VM console proxy tests as s390x-compatible.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Reasoning: Purely repetitive, homogeneous decorator additions across 10 test files with zero logic changes. Pattern consistency eliminates need for individualized reasoning per file—only verification that decorators are correctly placed and existing markers are preserved.

Possibly related PRs

Suggested labels

size/M, can-be-merged, branch-main, tox:verify-bugs-are-open:passed, lgtm-openshift-virtualization-qe-bot

Suggested reviewers

  • dshchedr
  • rnetser
  • vsibirsk
  • rlobillo
  • OhadRevah
  • hmeir
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description explains what the change does but doesn't fully populate the required template sections (Short description, More details, What this PR does, Issues fixed, Special notes, Jira ticket). Fill out template sections: add a concise short description, clarify why s390x support is needed, document any linked issues, and specify the Jira ticket status.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately summarizes the main change: adding s390x markers to infrastructure tests across multiple test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-virtualization-qe-bot-4

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open (optional)
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No WIP, hold, conflict labels
  5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • RoniKishner
  • dshchedr
  • geetikakay
  • rnetser
  • vsibirsk
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is automatically removed on each new commit
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants