-
Notifications
You must be signed in to change notification settings - Fork 53
[cnv-4.19] Backport Bitwarden CLI migration and --disabled-bitwarden flag
#3544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cnv-4.19
Are you sure you want to change the base?
Conversation
…-4.19 Cherry-picked from: - PR RedHatQE#2340: Bitwarden - move to using BW cli tool instead of the Python client - PR RedHatQE#3062: Allow running tests that do not require Bitwarden os_login secret
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3544 published |
|
/approve |
9fb82df
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3544 published |
Short description:
Backports Bitwarden changes from main to cnv-4.19:
os_loginsecret #3062: Add--disabled-bitwardenflag for tests without secretsChanges
Bitwarden CLI Migration
bitwarden-sdkPython package withbwsCLI toolbwsCLI andunziputilities/bitwarden.pyto use CLI commandsbitwarden-sdkfrom dependencies--disabled-bitwarden Flag
--disabled-bitwardenCLI option to CI groupget_artifactory_server_url()to support disabled modeARTIFACTORY_SERVERenv varMore details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: