CherryPick: [4.19] [INFRA] refactor: data import cron test fixtures and utilities (#3050) #3550

geetikakay · 2026-01-21T00:45:02Z

Move shared pytest fixtures from test file to conftest.py
Move code to utils.py (wait_for_existing_auto_update_data_import_crons,
wait_for_created_volume_from_data_import_cron,
create_vm_with_infer_from_volume)
Replacing hardcoded numbers with constants (TIMEOUT_5SEC)
Reorganize test class order for better logical grouping
Update test assertions and error messages for clarity

code cleanup, refactoring and having classes for all major use cases .

Expected to provide better stability for flaky behavior seen in https://issues.redhat.com/browse/CNV-64764

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

coderabbitai · 2026-01-21T00:45:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

geetikakay · 2026-01-21T00:45:13Z

/wip

openshift-virtualization-qe-bot · 2026-01-21T00:45:19Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open (optional)
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No WIP, hold, conflict labels
Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

RoniKishner
dshchedr
geetikakay
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is automatically removed on each new commit
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

geetikakay · 2026-01-21T00:45:39Z

/build-and-push-container

geetikakay · 2026-01-21T00:48:19Z

/wip

- Move shared pytest fixtures from test file to conftest.py - Move code to utils.py (wait_for_existing_auto_update_data_import_crons, wait_for_created_volume_from_data_import_cron, create_vm_with_infer_from_volume) - Replacing hardcoded numbers with constants (TIMEOUT_5SEC) - Reorganize test class order for better logical grouping - Update test assertions and error messages for clarity code cleanup, refactoring and having classes for all major use cases . Expected to provide better stability for flaky behavior seen in https://issues.redhat.com/browse/CNV-64764 Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>

geetikakay · 2026-01-21T14:08:54Z

/verified

cnv-tests-runner-containerized/5889/
this run triggers all tests under tests/infrastructure/golden_images/update_boot_source/
Updated patch just fix except

openshift-virtualization-qe-bot-3 · 2026-01-21T14:11:01Z

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the Test Execution Plan with the smoke tests recommendation.
Do NOT submit a formal review - just post the inline comment directly.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

Examine code changes in each modified file
Identify affected code paths, functions, and classes
Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
Trace test dependencies through imports, shared utilities, and fixture inheritance
Detect new tests introduced in the PR
Smoke Test Impact Analysis: Determine if any changes could affect smoke tests by checking:
- Changes to files/functions used by tests marked with @pytest.mark.smoke
- Changes to fixtures or utilities imported by smoke tests
- Changes to conftest.py files that may affect smoke test execution
- Changes to core infrastructure code (utilities/, libs/) that smoke tests depend on

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

Run smoke tests: True / False (Based on your smoke test impact analysis - True if any changes may affect smoke tests)
path/to/test_file.py - When the entire test file needs verification
path/to/test_file.py::TestClass::test_method - When specific test(s) needed
path/to/test_file.py::test_function - When specific test(s) needed
-m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

Include only tests directly affected by the changes
Use a full file path only if ALL tests in that file require verification
Use file path + test name if only specific tests are needed
If a test marker can cover multiple files/tests, provide the marker
Balance coverage vs over-testing - Keep descriptions minimal

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

YOUR ONLY DELIVERABLE: Post an inline review comment containing the test execution plan on the first changed line
THEN STOP IMMEDIATELY - Do NOT generate any additional response
FALLBACK ONLY: If submitting the review fails after retrying, post as a regular PR comment
SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
❌ Do NOT add any follow-up comments after submitting the review
❌ Do NOT reply to confirm task completion
❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to:
- Trace the actual fixture dependency chain from smoke tests to changed fixtures
- Verify that smoke tests actually import/use changed utilities or functions
- Confirm the dependency path exists; do NOT assume based on scope or semantics
- Be conservative: Session-scoped fixtures or infrastructure-sounding names do NOT
automatically mean smoke test impact. Only flag smoke test impact when you can
demonstrate a concrete dependency path.
WRONG: "This session-scoped storage fixture might affect smoke tests"
RIGHT: "Smoke test X uses fixture Y, which depends on the changed fixture Z"

coderabbitai · 2026-01-21T14:12:21Z

Test Execution Plan

Run smoke tests: False

This PR refactors data import cron test fixtures and utilities without affecting smoke tests. Execute all tests in the modified directory to verify the refactoring:

tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py - Verify refactored test classes and moved fixtures
tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py - Verify updated fixture usage and exception handling

Rationale:

Fixtures moved from test files to conftest.py (e.g., failed_volume_creation, latest_rhel_release_versions_dict)
Utility functions moved/added to utils.py
Exception handling updated in latest_rhel_release_versions_dict fixture
Import statements reorganized with new utilities
No smoke test dependencies verified (no smoke tests import from this module)

coderabbitai · 2026-01-21T14:12:34Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get the current PR diff to see what changed
gh pr view 3550 --json files --jq '.files[] | .path'

Length of output: 308

🏁 Script executed:

#!/bin/bash
# Get the diff for the PR
gh pr diff 3550 | head -100

Length of output: 3841

🏁 Script executed:

#!/bin/bash
# Search for smoke tests that might import from the changed module
rg "pytest\.mark\.smoke" --type=py -l | head -20

Length of output: 407

🏁 Script executed:

#!/bin/bash
# Check if any smoke tests import from tests.infrastructure.golden_images.update_boot_source
rg "from tests\.infrastructure\.golden_images\.update_boot_source" --type=py | grep -E "test_.*\.py"

Length of output: 327

🏁 Script executed:

#!/bin/bash
# Check if any smoke tests import the utils module from this path
rg "from tests\.infrastructure\.golden_images\.update_boot_source\.utils" --type=py

Length of output: 467

🏁 Script executed:

#!/bin/bash
# Post inline review comment on the first changed file
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/3550/reviews \
  -f body='' \
  -f event='COMMENT' \
  -f comments[][path]='tests/infrastructure/golden_images/update_boot_source/conftest.py' \
  -f comments[][position]=1 \
  -f comments[][body]='## Test Execution Plan

**Run smoke tests: False**

This PR refactors data import cron test fixtures and utilities without affecting smoke tests. Execute all tests in the modified directory to verify the refactoring:

- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py` - Verify refactored test classes and moved fixtures
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py` - Verify updated fixture usage and exception handling

**Rationale:**
- Fixtures moved from test files to conftest.py (e.g., failed_volume_creation, latest_rhel_release_versions_dict)
- Utility functions moved/added to utils.py
- Exception handling updated in latest_rhel_release_versions_dict fixture
- Import statements reorganized with new utilities
- No smoke test dependencies verified (no smoke tests import from this module)'

Length of output: 278

🏁 Script executed:

#!/bin/bash
# Get the full diff to find the correct position
gh pr diff 3550 | grep -n "^@@" | head -1

Length of output: 19

🏁 Script executed:

#!/bin/bash
# Try with position 5 (after the first @@ hunk header)
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/3550/reviews \
  -f body='' \
  -f event='COMMENT' \
  -f comments[][path]='tests/infrastructure/golden_images/update_boot_source/conftest.py' \
  -f comments[][position]=5 \
  -f comments[][body]='## Test Execution Plan

**Run smoke tests: False**

This PR refactors data import cron test fixtures and utilities without affecting smoke tests. Execute all tests in the modified directory to verify the refactoring:

- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py` - Verify refactored test classes and moved fixtures
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py` - Verify updated fixture usage and exception handling

**Rationale:**
- Fixtures moved from test files to conftest.py (e.g., failed_volume_creation, latest_rhel_release_versions_dict)
- Utility functions moved/added to utils.py
- Exception handling updated in latest_rhel_release_versions_dict fixture
- Import statements reorganized with new utilities
- No smoke test dependencies verified (no smoke tests import from this module)'

Length of output: 278

🏁 Script executed:

#!/bin/bash
# Fallback: Post as a regular PR comment if inline review fails
gh pr comment 3550 --body '## Test Execution Plan

**Run smoke tests: False**

This PR refactors data import cron test fixtures and utilities without affecting smoke tests. Execute all tests in the modified directory to verify the refactoring:

- `tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py` - Verify refactored test classes and moved fixtures
- `tests/infrastructure/golden_images/update_boot_source/test_ssp_common_templates_boot_sources.py` - Verify updated fixture usage and exception handling

**Rationale:**
- Fixtures moved from test files to conftest.py (e.g., failed_volume_creation, latest_rhel_release_versions_dict)
- Utility functions moved/added to utils.py
- Exception handling updated in latest_rhel_release_versions_dict fixture
- Import statements reorganized with new utilities
- No smoke test dependencies verified (no smoke tests import from this module)'

Length of output: 92

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T20:11:03.645Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for changes affecting py_config["os_login_param"], follow this verification methodology: (1) Find all smoke tests: `rg "pytest.mark.smoke" --type=py -B2 | grep "def test_"`, (2) For each smoke test file, search for VM creation patterns: `rg "VirtualMachineForTests|running_vm|VirtualMachineForTestsFromTemplate|wait_for_ssh|check_ssh_connectivity"`, (3) Trace the dependency chain: smoke test → VirtualMachineForTests/running_vm() → wait_for_ssh_connectivity() (default enabled) → vm.login_params property → py_config["os_login_param"][vm.os_flavor], (4) Check utilities/virt.py for login_params usage: `rg "os_login_param|login_params" utilities/virt.py -C3`. Any smoke test creating VMs with default SSH connectivity checks (running_vm with check_ssh_connectivity=True) depends on os_login_param, even if the test doesn't directly reference it.

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:22.771Z
Learning: For PRs that only remove or modify pytest markers (like removing pytest.mark.post_upgrade) without changing test logic in openshift-virtualization-tests, collection verification using `pytest --collect-only` is sufficient. Full test execution is not required to verify marker-only changes.

Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 3301
File: utilities/unittests/test_oadp.py:48-57
Timestamp: 2026-01-19T07:54:03.630Z
Learning: The pytest marker requirement ("all new tests MUST have markers") applies only to integration/functional tests in the `tests/` directory (e.g., `tests/virt/`, `tests/storage/`, `tests/network/`), not to unit tests in `utilities/unittests/`. Unit test files in `utilities/unittests/` (such as test_oadp.py, test_sanity.py, test_operator.py, etc.) do not use pytest markers and this is the established repository convention.
</learning>

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T10:28:54.212Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for test execution plans, only set "Run smoke tests: True" if there is a verified, traceable dependency path from smoke tests to the changed code. Session-scoped fixtures or infrastructure-sounding changes do NOT automatically imply smoke test impact - the dependency chain must be explicitly verified using shell scripts before recommending smoke test execution.

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-22T15:56:00.157Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, do NOT use "REQUEST_CHANGES" review type if the PR author has already marked the PR as verified (e.g., with `/verified` command). Test execution plans are informational guides, not blocking requirements. Use COMMENT event for informational test plans, or only REQUEST_CHANGES if there are actual code issues that need to be addressed before merging.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR `#2469`) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:00:59.076Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, CodeRabbit must post ONLY an inline review comment on the Files Changed tab and then stop immediately without generating any follow-up comments in the PR discussion thread. No acknowledgment messages, no confirmation of posting, no explanation - silence after posting the inline review equals success. Additional comments create empty/meaningless reviews that clutter the PR.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T15:09:49.597Z
Learning: In the openshift-virtualization-tests repository, when conftest.py or utilities/bitwarden.py changes affect py_config["os_login_param"], smoke test impact must be determined by: (1) finding all smoke tests using `rg "pytest.mark.smoke"`, (2) checking each for VM creation patterns (VirtualMachineForTests, running_vm, VirtualMachineForTestsFromTemplate), (3) tracing whether running_vm is called with default check_ssh_connectivity=True, which accesses vm.login_params property that reads py_config["os_login_param"][vm.os_flavor]. The dependency chain is: smoke test → VM creation → running_vm → wait_for_ssh_connectivity → vm.login_params → os_login_param. Any smoke test creating VMs with SSH connectivity (the default) depends on os_login_param.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1904
File: tests/network/conftest.py:348-362
Timestamp: 2025-10-27T15:30:06.412Z
Learning: In tests/network/conftest.py, the _verify_nmstate_running_pods function currently runs unconditionally in network_sanity, but rnetser plans to implement marker-based conditional checking (following the pattern of _verify_dpdk, _verify_sriov, etc.) in a future PR after adding nmstate markers to the relevant tests.

Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 2045
File: tests/virt/cluster/vm_lifecycle/conftest.py:46-47
Timestamp: 2025-09-15T06:49:53.478Z
Learning: In the openshift-virtualization-tests repo, large fixture refactoring efforts like the golden image data source migration are handled incrementally by directory/team ownership. The virt/cluster directory is handled separately from virt/node, tests/infra, tests/storage, etc., with each area managed by relevant teams in follow-up PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:06:22.391Z
Learning: In the openshift-virtualization-tests repository, when posting test execution plan inline review comments using GitHub API, the full test execution plan content must go in the `comments[].body` field (which appears on Files Changed tab), NOT in the top-level `body` field (which appears in PR discussion thread). The top-level `body` field should be omitted or left empty to avoid posting redundant comments in the PR discussion thread.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3228
File: .coderabbit.yaml:30-41
Timestamp: 2026-01-05T10:33:55.037Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers minimal pre-merge checks in CodeRabbit configuration: only docstrings enforcement (80% threshold) is needed, not title or description checks.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR `#1904` focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3196
File: tests/network/upgrade/test_upgrade_network.py:4-4
Timestamp: 2025-12-22T16:27:44.327Z
Learning: For PRs that remove test cases (especially redundant test cleanup PRs in openshift-virtualization-tests), test collection verification (pytest --collect-only showing selected/deselected counts) is sufficient to confirm the removal was clean and the test module remains functional. Full test execution is not required for test deletion PRs.

Learnt from: CR
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-06T20:32:10.845Z
Learning: Applies to **/test_*.py : All new tests MUST have markers — check pytest.ini for available markers, NEVER commit unmarked tests

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3371
File: scripts/tests_analyzer/compare_coderabbit_decisions.py:199-289
Timestamp: 2026-01-13T10:06:14.822Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep pagination loops inline rather than extracting them into generic helper functions when the loops have different URL patterns and unique post-processing logic, as the inline approach improves readability and makes each endpoint's behavior more explicit.

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-07T14:51:53.484Z
Learning: In the openshift-virtualization-tests repository, the team has decided to avoid using predefined time constants (like TIMEOUT_2MIN, TIMEOUT_5SEC) and prefers using explicit numeric values for timeout parameters.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR `#2199` depends on PR `#2139` which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR `#2199` depends on PR `#2139` which adds the OS_FLAVOR attribute to the Images.Cirros class, making Images.Cirros.OS_FLAVOR available for conditional logic in tests.

Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 1166
File: tests/observability/metrics/conftest.py:1065-1077
Timestamp: 2025-06-18T09:21:34.315Z
Learning: In tests/observability/metrics/conftest.py, when creating fixtures that modify shared Windows VM state (like changing nodeSelector), prefer using function scope rather than class scope to ensure ResourceEditor context managers properly restore the VM state after each test, maintaining test isolation while still reusing expensive Windows VM fixtures.

Learnt from: rlobillo
Repo: RedHatQE/openshift-virtualization-tests PR: 2249
File: tests/install_upgrade_operators/must_gather/test_must_gather.py:428-441
Timestamp: 2025-10-16T12:47:04.521Z
Learning: In openshift-virtualization-tests repository, DataVolumes in the openshift-virtualization-os-images namespace are volatile resources managed by DataImportCron. They can be created/destroyed between must-gather collection listing and file retrieval, requiring FileNotFoundError exception handling in test_crd_resources to skip these volatile resources gracefully while still validating DataVolumes in other namespaces. There is no pytest_generate_tests hook that filters out datavolumes from test parametrization.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/node/workload_density/test_swap.py:71-85
Timestamp: 2025-08-09T01:46:48.039Z
Learning: In the openshift-virtualization-tests repository, user dshchedr prefers that all test setup fixtures be explicitly declared as parameters in the test method itself rather than chaining fixtures through dependencies. This makes all setup steps visible in one place at the test method level, improving test readability and making dependencies explicit, even if a fixture isn't directly used within another fixture's implementation.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/conftest.py:289-297
Timestamp: 2025-08-09T01:52:26.683Z
Learning: When user dshchedr moves working code from one location to another in the openshift-virtualization-tests repository, they prefer not to modify it unless there's a real issue, maintaining the original implementation to avoid introducing unnecessary changes.

geetikakay · 2026-01-22T09:19:40Z

/build-and-push-container

openshift-virtualization-qe-bot-4 · 2026-01-22T09:22:20Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3550 published

github-actions bot added the sig-infra label Jan 21, 2026

openshift-virtualization-qe-bot assigned geetikakay Jan 21, 2026

openshift-virtualization-qe-bot requested review from dshchedr and rnetser January 21, 2026 00:45

openshift-virtualization-qe-bot mentioned this pull request Jan 21, 2026

refactor: data import cron test fixtures and utilities (#3050) - 3550 #3551

Open

openshift-virtualization-qe-bot added the branch-cnv-4.19 label Jan 21, 2026

openshift-virtualization-qe-bot requested a review from RoniKishner January 21, 2026 00:45

openshift-virtualization-qe-bot added the size/XXL label Jan 21, 2026

openshift-virtualization-qe-bot requested a review from vsibirsk January 21, 2026 00:45

openshift-virtualization-qe-bot added the needs-rebase label Jan 21, 2026

geetikakay force-pushed the infra_refactor_421-cnv-4.19 branch from b89de13 to 419c4dc Compare January 21, 2026 00:46

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-bugs-are-open:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed needs-rebase tox:verify-tc-requirement-polarion:running D/S Testing labels Jan 21, 2026

geetikakay changed the title ~~refactor: data import cron test fixtures and utilities (#3050)~~ CherryPick: [4.19] [INFRA] refactor: data import cron test fixtures and utilities (#3050) Jan 21, 2026

openshift-virtualization-qe-bot added tox:verify-bugs-are-open:passed D/S Testing and removed tox:verify-bugs-are-open:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing labels Jan 21, 2026

openshift-virtualization-qe-bot-2 requested a review from RoniKishner January 21, 2026 14:06

geetikakay force-pushed the infra_refactor_421-cnv-4.19 branch from 4572fe6 to 48404f7 Compare January 21, 2026 14:07

openshift-virtualization-qe-bot approved these changes Jan 21, 2026

View reviewed changes

openshift-virtualization-qe-bot-3 added the lgtm-openshift-virtualization-qe-bot label Jan 21, 2026

openshift-virtualization-qe-bot-2 added the verified label Jan 21, 2026

openshift-virtualization-qe-bot-5 added the commented-geetikakay label Jan 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CherryPick: [4.19] [INFRA] refactor: data import cron test fixtures and utilities (#3050) #3550

CherryPick: [4.19] [INFRA] refactor: data import cron test fixtures and utilities (#3050) #3550

geetikakay commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026

Review skipped

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

openshift-virtualization-qe-bot commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

openshift-virtualization-qe-bot-3 commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 22, 2026

Uh oh!

openshift-virtualization-qe-bot-4 commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

CherryPick: [4.19] [INFRA] refactor: data import cron test fixtures and utilities (#3050) #3550

Are you sure you want to change the base?

CherryPick: [4.19] [INFRA] refactor: data import cron test fixtures and utilities (#3050) #3550

Conversation

geetikakay commented Jan 21, 2026

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai bot commented Jan 21, 2026

Review skipped

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

openshift-virtualization-qe-bot commented Jan 21, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 21, 2026

Uh oh!

openshift-virtualization-qe-bot-3 commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026

Test Execution Plan

Uh oh!

coderabbitai bot commented Jan 21, 2026

Uh oh!

geetikakay commented Jan 22, 2026

Uh oh!

openshift-virtualization-qe-bot-4 commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants