CherryPicked: [cnv-4.21] net,tests,vm import: add basic coverage #3564
+210
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic coverage for testing the import of a VM from an external provider to CUDN namespace: network data persistence and connectivity The PR includes: 1) adding `from_existing` class method for BaseVirtualMachine: this class method allows you to create a class object for an existing VM in the cluster. 2) tests automation itself with related fixtures adding\fixes. ##### jira-ticket: https://issues.redhat.com/browse/CNV-63871 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Import/manage existing VMs through the VM API; extract primary MAC/IP; added fixtures for imported and local VMs; module-level test markers and constants. * **Bug Fixes** * Improved VM power on/off flow with better logging, timeout handling, and clearer error when VM network interface is missing. * **Tests** * Expanded tests validating MAC/IP preservation, egress, inter-VM TCP connectivity, and connectivity after migration. * **Chores** * Added a new dependency for data handling. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-4
requested review from
Anatw,
RoniKishner,
dshchedr,
vsibirsk and
yossisegev
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified see original PR |
openshift-virtualization-qe-bot
added
tox:verify-bugs-are-open:passed
openshift-virtualization-qe-bot
approved these changes
Jan 21, 2026
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 16217 🏁 Script executed: Length of output: 1118 🏁 Script executed: Length of output: 426 🏁 Script executed: Length of output: 1728 🧠 Learnings used |
EdDev
approved these changes
Jan 21, 2026
Contributor
EdDev
left a comment
EdDev
left a comment
There was a problem hiding this comment.
Thank you.
As this is a backport, there is a need to reason for the test being backported to a stable release branch.
If the PR description cannot be edited (automated by the bot), a comment can be added on the PR to express it.
As I know the reasoning already, you can add the comment for formality even after this PR is merged. But if you can do it before, it will be great.
/approve
azhivovk
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #3387.
There was no any manual intervention into the code, only cherry-pick itself.
Rationale:
VM migration from the external provider is a part of 4.21 GA, so, it should be in the current branch.
Jira-ticket: https://issues.redhat.com/browse/CNV-63871