Add test for connectivity between localnet VMs #464

sbahar619 · 2025-03-13T09:52:45Z

Short description:

Add test for connectivity between localnet VMs

More details:

Add test for connectivity between localnet VMs

Introduced a new test to verify connectivity between VMs on the
localnet network. This test ensures that VMs within the localnet
network have connectivity.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

https://issues.redhat.com/browse/CNV-55290

sbahar619 · 2025-03-13T09:53:02Z

/wip

ghost · 2025-03-13T09:53:07Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
- You can add extra args to the Podman build command
  - Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge
to assign reviewer to PR use /assign-reviewer @<reviewer>

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container
/retest all: Retest all

Supported labels

hold
verified
wip
lgtm

sbahar619 · 2025-04-30T05:49:08Z

/verified

EdDev

/approve

EdDev · 2025-04-30T09:33:09Z

/approve

Anatw

Thank you!

tests/network/localnet/test_localnet.py

EdDev · 2025-05-04T09:02:33Z

/check-can-merge

vsibirsk · 2025-05-04T09:12:18Z

/approve

sbahar619 · 2025-05-04T10:16:28Z

/check-can-merge

sbahar619 · 2025-05-04T10:20:25Z

/check-can-merge

ghost · 2025-05-04T10:23:26Z

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-464.

sbahar619 · 2025-05-12T07:22:55Z

/cherry-pick cnv-4.18

* Ensure boot disk is first in list of VM disks and volumes The default boot image must be the first disk for correct VM behavior. Changed disk and volume insertion to use insert instead of append so the boot image appears first in the disks and volumes lists. Signed-off-by: Shahaf Bahar <[email protected]> * Add test for connectivity between localnet VMs Introduced a new test to verify connectivity between VMs on the localnet network. This test ensures that VMs within the localnet network have connectivity. Signed-off-by: Shahaf Bahar <[email protected]> --------- Signed-off-by: Shahaf Bahar <[email protected]>

* Utilities - Add NodeNetworkConfigurationPolicy resource to libs/net (#218) - As part of the initiative to create simpler resources and reduce dependency, this PR introduces a new NNCP resource in the network's team libs directory. - The new NNCP is used in an existing test - test_linux_bridge_functionality. Signed-off-by: Anat Wax <[email protected]> * tests, net, libs, nncp: On update/patch, assure correct status update (#733) * tests, network: Cover tests.network.libs with mypy validation Signed-off-by: Edward Haas <[email protected]> * tests, net, libs, nncp: On update/patch, assure correct status update When mutating an existing NNCP object, it is common to wait for a condition status of success (condition type "Available"). However, it has been observed or bare-metal clusters that the observed condition is the previous one and is not reflecting the actual state after the spec update/patch. In order to handle these cases, the condition timestamp is used to assure it has been updated post the change. Other alternatives have been found unsafe, like the option of waiting for an intermediate state (e.g. "progressing"). It is unsafe because the state is in transition and that can be quicker than the sampling performed by the test tools. The current NNCP object updates the spec only when performing the clean-up step (on teardown). At that step the previous created interfaces are being removed. Any future exposure of update/patch requires this technique to assure successful operation. Signed-off-by: Edward Haas <[email protected]> * tests, net, libs, nncp: Relocate the resource patching at clean_up The clean_up method is used to perform teardown operations for any resource. For the NNCP it is used to revert the interfaces additions (by deleting them). It makes sense to place the update/patch call at the cleanup upper level so any other future changes will be able to re-use the same single patch operation. Signed-off-by: Edward Haas <[email protected]> * tests, net, libs, nncp: Drop the condition class and fix func signature Signed-off-by: Edward Haas <[email protected]> --------- Signed-off-by: Edward Haas <[email protected]> * tests, net, libs: Introduce network cloud-init data structure (#754) * tests, net, libs: Introduce network cloud-init data structure Introduce a new data structure for network cloud-init. It is aimed to replace the existing dict-based configuration. Usage example: ``` from tests.network.libs import cloudinit nd = cloudinit.NetworkData(ethernets={ "eth0": EthernetDevice( dhcp4=False, addresses=["1.1.1.1/24", "d10:0:2::2"], gateway6="d10:0:2::1", ) }) nd_yaml = yaml.safe_dump(cloudinit.todict(netdata=nd), sort_keys=False) cloudinit_dict = cloudinit.cloudinit(netdata=nd) ``` Signed-off-by: Edward Haas <[email protected]> * tests, net, bond: First use of the new structured cloud-init network Signed-off-by: Edward Haas <[email protected]> * tests, net, libs: Introduce 'apimachinery' module The new module is aimed to contain API related helpers. First candidate: the dict normalization which is used to translate a dataclass to a dict. Signed-off-by: Edward Haas <[email protected]> --------- Signed-off-by: Edward Haas <[email protected]> * tests, net, libs, nncp: Assure NNCP resource exists, status & conditions absense is treated correctly. (#876) * tests, net, libs, nncp: Assure resource is waited for on deployment Currently, the default resource deployment is not waiting for the resource to appear. We are interested for the NNCP resources to assure that the resource exists before we continue. This change assures that the `self.instance` exists and with it the `status`. Signed-off-by: Edward Haas <[email protected]> * tests, net, libs, nncp: Do not assume NNCP 'status' & 'conditions' exist On NNCP resource creation, the status and/or conditions may not yet be populated. Assure such scenarios are treated. Signed-off-by: Edward Haas <[email protected]> --------- Signed-off-by: Edward Haas <[email protected]> * Add test for connectivity between localnet VMs (#464) * Ensure boot disk is first in list of VM disks and volumes The default boot image must be the first disk for correct VM behavior. Changed disk and volume insertion to use insert instead of append so the boot image appears first in the disks and volumes lists. Signed-off-by: Shahaf Bahar <[email protected]> * Add test for connectivity between localnet VMs Introduced a new test to verify connectivity between VMs on the localnet network. This test ensures that VMs within the localnet network have connectivity. Signed-off-by: Shahaf Bahar <[email protected]> --------- Signed-off-by: Shahaf Bahar <[email protected]> --------- Signed-off-by: Anat Wax <[email protected]> Signed-off-by: Edward Haas <[email protected]> Signed-off-by: Shahaf Bahar <[email protected]> Co-authored-by: ‪Anat Wax <[email protected]> Co-authored-by: Edward Haas <[email protected]>

github-actions bot added the sig-network label Mar 13, 2025

ghost added size/XXL has-conflicts labels Mar 13, 2025

ghost requested a review from duyanyan March 13, 2025 09:53

ghost added the branch-main label Mar 13, 2025

ghost mentioned this pull request Mar 13, 2025

Add test for connectivity between localnet VMs - 464 #465

Closed

ghost requested review from yossisegev, geetikakay, jpeimer, Anatw, vsibirsk, jerry7z and akri3i March 13, 2025 09:53

ghost added the wip label Mar 13, 2025

ghost requested a review from RoniKishner March 13, 2025 09:53

ghost changed the title ~~Add test for connectivity between localnet VMs~~ WIP: Add test for connectivity between localnet VMs Mar 13, 2025

ghost requested review from hmeir, kbidarkar, OhadRevah, dshchedr, dbasunag and SiboWang1997 March 13, 2025 09:53

polarion-jenkins added tox:verify-bugs-are-open:running D/S Testing tox:verify-bugs-are-open:passed D/S Testing and removed tox:verify-bugs-are-open:running D/S Testing labels Mar 13, 2025

polarion-jenkins previously approved these changes Mar 13, 2025

View reviewed changes

ghost added the lgtm-polarion-jenkins label Mar 13, 2025

sbahar619 dismissed polarion-jenkins’s stale review via c8bf3c4 March 16, 2025 08:07

ghost added the lgtm-polarion-jenkins label Apr 30, 2025

ghost added the verified label Apr 30, 2025

EdDev approved these changes Apr 30, 2025

View reviewed changes

ghost added the lgtm-EdDev label Apr 30, 2025

ghost added the approved-EdDev label Apr 30, 2025

Anatw approved these changes Apr 30, 2025

View reviewed changes

tests/network/localnet/test_localnet.py Show resolved Hide resolved

dbasunag1 added the lgtm-Anatw label Apr 30, 2025

rnetser approved these changes May 4, 2025

View reviewed changes

dbasunag1 added the lgtm-rnetser label May 4, 2025

vsibirsk approved these changes May 4, 2025

View reviewed changes

yossisegev approved these changes May 4, 2025

View reviewed changes

dbasunag1 added lgtm-vsibirsk lgtm-yossisegev labels May 4, 2025

vsibirsk enabled auto-merge (squash) May 4, 2025 09:12

ghost added approved-vsibirsk can-be-merged labels May 4, 2025

vsibirsk disabled auto-merge May 4, 2025 10:21

vsibirsk merged commit f22bb6c into RedHatQE:main May 4, 2025
7 checks passed

sbahar619 mentioned this pull request May 12, 2025

[cnv-4.18] backport localnet test and its dependencies #944

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add test for connectivity between localnet VMs #464

Add test for connectivity between localnet VMs #464

Uh oh!

sbahar619 commented Mar 13, 2025 •

edited

Loading

Uh oh!

sbahar619 commented Mar 13, 2025

Uh oh!

ghost commented Mar 13, 2025

Uh oh!

sbahar619 commented Apr 30, 2025

Uh oh!

EdDev left a comment

Uh oh!

EdDev commented Apr 30, 2025

Uh oh!

Anatw left a comment

Uh oh!

Uh oh!

EdDev commented May 4, 2025

Uh oh!

vsibirsk commented May 4, 2025

Uh oh!

sbahar619 commented May 4, 2025

Uh oh!

sbahar619 commented May 4, 2025

Uh oh!

Uh oh!

ghost commented May 4, 2025

Uh oh!

sbahar619 commented May 12, 2025

Uh oh!

Uh oh!

Add test for connectivity between localnet VMs #464

Add test for connectivity between localnet VMs #464

Uh oh!

Conversation

sbahar619 commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

sbahar619 commented Mar 13, 2025

Uh oh!

ghost commented Mar 13, 2025

Uh oh!

sbahar619 commented Apr 30, 2025

Uh oh!

EdDev left a comment

Choose a reason for hiding this comment

Uh oh!

EdDev commented Apr 30, 2025

Uh oh!

Anatw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EdDev commented May 4, 2025

Uh oh!

vsibirsk commented May 4, 2025

Uh oh!

sbahar619 commented May 4, 2025

Uh oh!

sbahar619 commented May 4, 2025

Uh oh!

Uh oh!

ghost commented May 4, 2025

Uh oh!

sbahar619 commented May 12, 2025

Uh oh!

Uh oh!

sbahar619 commented Mar 13, 2025 •

edited

Loading