Skip to content

Adding windows vms for testing network metrics #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Jun 10, 2025

Conversation

OhadRevah
Copy link
Contributor

@OhadRevah OhadRevah commented Mar 25, 2025

Short description:

Added windows tests for network metrics that using vms.

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

https://issues.redhat.com/browse/CNV-58656

Summary by CodeRabbit

  • New Features
    • Added support for testing network metrics on Windows virtual machines, including network traffic generation and metric verification.
  • Bug Fixes
    • Improved error logging for network packet metric validation to provide clearer diagnostics.
  • Refactor
    • Separated Linux and Windows network metric tests for better organization and clarity.
    • Replaced hardcoded metric names with shared constants.
  • Documentation
    • Added type annotations and detailed docstrings to utility functions for improved code clarity.
  • Tests
    • Enhanced test coverage for network metrics, including new fixtures and parameter updates for Windows VM scenarios.

@dbasunag1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

Added windows tests for network metrics that using vms.
@OhadRevah
Copy link
Contributor Author

/verified

@rnetser
Copy link
Collaborator

rnetser commented Jun 10, 2025

/approve
/lgtm

@rnetser rnetser merged commit 7b7ca7a into RedHatQE:main Jun 10, 2025
8 checks passed
@openshift-virtualization-qe-bot-3

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-584.

@OhadRevah OhadRevah deleted the addingWindowsVmsToNetworkMetrics branch June 10, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.