Skip to content

Conversation

@OhadRevah
Copy link
Contributor

Short description:

Added tests for the metrics in TestVMIMetrics test class
with windows vm, also added test for metric
kubevirt_vm_info.

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

https://issues.redhat.com/browse/CNV-58793

Adding windows vm to these metrics tests:
vmi_domain_total_memory_bytes
vmi_used_memory_bytes
kubevirt_vmi_info
kubevirt_vm_info
Added test for kubevirt_vm_info metric.
Added tests for the metrics in TestVMIMetrics test class
with windows vm, also added test for metric
kubevirt_vm_info.
@dbasunag1 dbasunag1 requested a review from dbasunag April 6, 2025 14:14
@dbasunag1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@OhadRevah
Copy link
Contributor Author

/build-and-push-contianer

@OhadRevah
Copy link
Contributor Author

/build-and-push-container

@ghost
Copy link

ghost commented Apr 6, 2025

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-695 published

@OhadRevah
Copy link
Contributor Author

/verified

@ghost ghost added the lgtm-jpeimer label Apr 21, 2025
@dshchedr dshchedr enabled auto-merge (squash) April 22, 2025 18:32
@dshchedr dshchedr merged commit a48ef6c into RedHatQE:main Apr 22, 2025
7 checks passed
@ghost
Copy link

ghost commented Apr 22, 2025

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-695.

@ghost
Copy link

ghost commented Apr 22, 2025

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

@OhadRevah OhadRevah deleted the kubevirt_vm_info branch April 27, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants