[Virt] Add suffix for s390x template names for Common templates tests

[jdao-rh]

Short description:

Adds support of test on s390x by adding correct template names for virt/cluster/commontemplate/general tests

More details:

• checks node arch
• Adds "-s390x" suffix to common templates when run on s390x

What this PR does / why we need it:

Allows virt/cluster/commontemplate/general to be run against s390x arch

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests
  • Enhanced test coverage to dynamically handle template lists based on cluster CPU architecture, including architecture-specific template naming and restrictions.
• New Features
  • Added support for the s390x CPU architecture in template selections and constants.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

## Walkthrough

Architecture-awareness is added to template list generation functions by introducing a required `cluster_arch` parameter. Template lists and names are adapted based on architecture, particularly for "s390x". The pytest fixture dynamically determines the node CPU architecture for accurate template expectations. A new constant `S390X` is added to CPU architecture constants.

## Changes

| File(s)                                                   | Change Summary                                                                                                                                                                                                                      |
|----------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| tests/virt/cluster/common_templates/general/test_base_template.py | Updated template list functions to accept `cluster_arch`, adapted template naming and filtering for "s390x" architecture, and modified pytest fixture to detect node CPU architecture dynamically and pass it to these functions.    |
| utilities/constants.py                                    | Added new CPU architecture constant `S390X = "s390x"` and `S390X_TEMPLATE_SUFFIX = "-s390x"` alongside existing constants.                                                                                                        |

## Suggested labels

`verified`, `size/XS`, `can-be-merged`, `tox:verify-bugs-are-open:passed`, `lgtm-rnetser`, `approved-rnetser`

## Suggested reviewers

- vsibirsk
- dshchedr
- kbidarkar
- akri3i

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dbasunag1]

Report bugs in Issues

The following are automatically added:

• Add reviewers from OWNER file (in the root of the repository) under reviewers section.
• Set PR size label.
• New issue is created for the PR. (Closed when PR is merged/closed)
• Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

• To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
• To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
  • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
  • Cherry-pick will be started when PR is merged
• To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • You can add extra args to the Podman build command
    • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
• To add a label by comment use /<label name>, to remove, use /<label name> cancel
• To assign reviewers based on OWNERS file use /assign-reviewers
• To check if PR can be merged use /check-can-merge
• to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

• /approve from one of the approvers.
• Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

• Approvers:

  • dshchedr
  • vsibirsk

• Reviewers:

  • SiboWang1997
  • akri3i
  • dshchedr
  • jerry7z
  • kbidarkar
  • vsibirsk

Supported /retest check runs

• /retest tox: Retest tox
• /retest build-container: Retest build-container
• /retest all: Retest all

Supported labels

• hold
• verified
• wip
• lgtm
• approve

[rabin-io]

/build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=06faf24b83a33dec0cd228b9b690a1d440f240f2

[dbasunag1]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-921 published

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/14223

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/14226

[openshift-virtualization-qe-bot]

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/14227

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has not been updated in past 30 days.