Update internal-http container image #973

stesrn · 2025-05-15T09:22:16Z

This patch updates the internal-http container image used in cnv-tests. The new version v1.1.0 of internal-http multi-arch image manifest also includes container image for s390x architecture in addition to amd64(x86_64) and arm64(aarch64)

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

NONE

Summary by CodeRabbit

Chores
- Updated the container image version used for the internal HTTP server deployment to v1.1.0.

coderabbitai · 2025-05-15T09:22:24Z

Walkthrough

The change updates the container image version in the internal HTTP server deployment template within the test configuration. The image tag is modified from version v1.0.0 to v1.1.0 in the relevant dictionary used by a test fixture. No other logic or structure is altered.

Changes

File(s)	Change Summary
tests/storage/conftest.py	Updated the internal HTTP server container image tag from v1.0.0 to v1.1.0 in the deployment template.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06365e0 and 3084f07.

📒 Files selected for processing (1)

tests/storage/conftest.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/storage/conftest.py

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: can-be-merged
GitHub Check: can-be-merged
GitHub Check: can-be-merged
GitHub Check: can-be-merged
GitHub Check: tox
GitHub Check: build-container

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ghost · 2025-05-15T09:22:32Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
- You can add extra args to the Podman build command
  - Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge
to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

/approve from one of the approvers.
Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

Approvers:
- jpeimer
Reviewers:
- duyanyan
- jpeimer

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container
/retest all: Retest all

Supported labels

hold
verified
wip
lgtm
approve

stesrn · 2025-05-15T09:30:07Z

/build-and-push-container

dbasunag1 · 2025-05-15T09:30:46Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-973 published

stesrn · 2025-05-15T17:34:21Z

/verified

This patch updates the internal-http container image used in cnv-tests. The new version v1.1.0 of internal-http multi-arch image manifest also includes container image for s390x architecture in addition to amd64(x86_64) and arm64(aarch64)

polarion-jenkins

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/11075

stesrn · 2025-05-15T17:42:48Z

/verified

rnetser · 2025-05-18T10:11:05Z

@stesrn please note that the fedora image was reverted

rnetser · 2025-05-18T10:15:06Z

test comment

rnetser · 2025-05-18T10:16:59Z

tests/storage/conftest.py

@@ -82,7 +82,7 @@
        "containers": [
            {
                "name": "http",
-                "image": "quay.io/openshift-cnv/qe-cnv-tests-internal-http:v1.0.0",
+                "image": "quay.io/openshift-cnv/qe-cnv-tests-internal-http:v1.1.0",


@stesrn please note that the fedora image was reverted

@rnetser ok. I just the same amd64 and arm64 container images, and used s390x container image built by IBM team to build this image manifest. All the smoke tests passed, was any others failed ?

@stesrn i just want to make sure we do not have any surprises with the images that may affect other teams. Smoke tests may not enough (as the tests do not use all images)

This is only used in images_internal_http_server, which is only used in several storage tests, so if these tests are fine - we should be good

@jpeimer Thank you very much. I will run those tests to make sure the new container image is good

@stesrn can you please remove verified label (add /verified cancel comment) and re-add once verified again? thanks

stesrn · 2025-05-27T09:35:09Z

/verified cancel

stesrn · 2025-05-28T17:27:29Z

/build-and-push-container

ghost · 2025-05-28T17:28:01Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-973 published

rnetser · 2025-05-29T06:44:33Z

/retest build-container

ghost requested a review from jpeimer May 15, 2025 09:22

ghost assigned stesrn May 15, 2025

ghost mentioned this pull request May 15, 2025

Update internal-http container image - 973 #974

Open

ghost requested a review from duyanyan May 15, 2025 09:22

ghost added branch-main size/XS labels May 15, 2025

polarion-jenkins approved these changes May 15, 2025

View reviewed changes

ghost added the lgtm-polarion-jenkins label May 15, 2025

jpeimer approved these changes May 15, 2025

View reviewed changes

dbasunag1 added the lgtm-jpeimer label May 15, 2025

ghost added the verified label May 15, 2025

Update internal-http container image

3084f07

This patch updates the internal-http container image used in cnv-tests. The new version v1.1.0 of internal-http multi-arch image manifest also includes container image for s390x architecture in addition to amd64(x86_64) and arm64(aarch64)

stesrn force-pushed the update-internal-http-container branch from 06365e0 to 3084f07 Compare May 15, 2025 17:35

ghost removed verified lgtm-jpeimer lgtm-polarion-jenkins labels May 15, 2025

ghost requested a review from jpeimer May 15, 2025 17:36

polarion-jenkins added tox:verify-tc-requirement-polarion:running D/S Testing and removed tox:verify-tc-requirement-polarion:passed D/S Testing labels May 15, 2025

polarion-jenkins added tox:verify-bugs-are-open:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing tox:verify-bugs-are-open:failed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-bugs-are-open:running D/S Testing labels May 15, 2025

polarion-jenkins requested changes May 15, 2025

View reviewed changes

dbasunag1 added the changes-requested-polarion-jenkins label May 15, 2025

ghost added the verified label May 15, 2025

stesrn requested a review from polarion-jenkins May 15, 2025 17:44

rnetser reviewed May 18, 2025

View reviewed changes

ghost added commented-rnetser commented-stesrn commented-jpeimer labels May 18, 2025

ghost removed the verified label May 27, 2025

Merge branch 'main' into update-internal-http-container

566a796

ghost removed commented-jpeimer commented-stesrn changes-requested-polarion-jenkins commented-rnetser labels May 28, 2025

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:passed D/S Testing tox:verify-tc-requirement-polarion:running D/S Testing labels May 28, 2025

Update internal-http container image #973

Are you sure you want to change the base?

Update internal-http container image #973

Uh oh!

Conversation

stesrn commented May 15, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ghost commented May 15, 2025

Uh oh!

stesrn commented May 15, 2025

Uh oh!

dbasunag1 commented May 15, 2025

Uh oh!

stesrn commented May 15, 2025

Uh oh!

polarion-jenkins left a comment

Choose a reason for hiding this comment

Uh oh!

stesrn commented May 15, 2025

Uh oh!

rnetser commented May 18, 2025

Uh oh!

rnetser commented May 18, 2025

Uh oh!

rnetser May 18, 2025

Choose a reason for hiding this comment

Uh oh!

stesrn May 19, 2025

Choose a reason for hiding this comment

Uh oh!

rnetser May 21, 2025

Choose a reason for hiding this comment

Uh oh!

jpeimer May 22, 2025

Choose a reason for hiding this comment

Uh oh!

stesrn May 22, 2025

Choose a reason for hiding this comment

Uh oh!

rnetser May 22, 2025

Choose a reason for hiding this comment

Uh oh!

stesrn commented May 27, 2025

Uh oh!

stesrn commented May 28, 2025

Uh oh!

ghost commented May 28, 2025

Uh oh!

rnetser commented May 29, 2025

Uh oh!

Uh oh!

stesrn commented May 15, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)