-
Notifications
You must be signed in to change notification settings - Fork 35
Refactor OS matrix to support different architectures #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rnetser
wants to merge
49
commits into
RedHatQE:main
Choose a base branch
from
rnetser:refactor-arch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
61db6af
feat: refactor image architectures
rnetser 341e3be
fix versions and refactor functio location
rnetser b1d827a
get os from py_config only if exists
rnetser f18a9cf
add missing file
rnetser 50b0ad8
fix tox and use global_config_x86.py
rnetser df53454
add todo on cirros s390x class
rnetser 7c4f0fa
catch AttributeError it not set
rnetser a8fa849
catch AttributeError it not set
rnetser 2f333d9
catch AttributeError it not set
rnetser ed3a9e5
update get_test_images_arch_class to upper
rnetser ff6f07c
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 6c5a142
address comments and refactor archs
rnetser ceef9b6
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 4b8216d
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 71caec3
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser a86e8a3
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser dbf91d9
Merge branch 'main' of github.com:rnetser/openshift-virtualization-te…
rnetser f930f62
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser ad21992
Move base images to data classes
rnetser ce0178c
resolve merge conflicts
rnetser 652f5a8
add markers to pytest.ini
rnetser f02bf0a
address comments
rnetser bd1ce05
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 74c3951
address review comments
rnetser a335779
add to tox
rnetser 52f1e8f
fix tox
rnetser 24d573d
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 6e7b452
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser f5019b0
update markers description
rnetser 721bcba
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 9cc19de
resolve conflicts
rnetser 093716c
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 7482645
address comments
rnetser 61e1c08
fix dataclasses
rnetser d0425b1
add OS_VERSION_STR to all
rnetser 6163446
resolve conflicts
rnetser 0c0df1b
add docstrings
rnetser 613957c
fix pre-commit
rnetser 3c0d340
fix missing matrix flows
rnetser 3b516b8
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 933ca3d
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 8be8d19
Merge branch 'main' of https://github.com/RedHatQE/openshift-virtuali…
rnetser 3e86364
update gcp ini file
rnetser e4087ba
fix windows dir
rnetser 811fe53
fix dir assignment
rnetser ec28a19
update readme
rnetser 0d5c61b
re-add removed test
rnetser b532999
resolve conflicts
rnetser dcdff86
resolve conflicts
rnetser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont want a default global config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no; if you add one in cmd, the plugin will use both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense
And what about the jenkins jobs?
Do they set --tc-file explicity? because if they dont, 4.19 amd jobs may break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there's a jira for them to work on this. this PR cannot be merged before they make the change