fix not search

CHANGES.rst

@@ -4,6 +4,8 @@ Changelog
 5.8.1 (unreleased)
 ------------------
 
+- Fix Searches with "not" in a KeywordIndex do not return records that do not contain a value for the index
+  [mamico]
 - Fix issue with event search in @querystring-search override:
   converting a timezone-aware DateTime to utcdatetime causes a problem when searching for
   "today", as it shifts start=day x at 00:00 to start=day x-1 at 22:00 in GMT+2 timezone.

src/redturtle/volto/monkey.py

@@ -189,11 +189,9 @@ def search_for_similar(*args, **kwargs):
 
     original_obj = args and args[0] or None
 
-    if (
-        os.environ.get("REDTURTLE_VOLTO_ENABLE_SEARCH_FOR_SIMILAR", default=None)
-        and original_obj  # noqa
-    ):
-        return original_obj._old_search_for_similar()
+    if os.environ.get("REDTURTLE_VOLTO_ENABLE_SEARCH_FOR_SIMILAR"):
+        if original_obj:
+            return original_obj._old_search_for_similar()
 
     return []
 
@@ -217,3 +215,17 @@ def plone_restapi_blocks_linkintegrity_blocksretriever_retrieveLinks(self):
         ):
             links |= set(handler(block))
     return links
+
+
+def _get_object_keywords(self, obj, attr):
+    """Products.PluginIndexes.KeywordIndex.KeywordIndex.KeywordIndex._get_object_keywords patch
+
+    See: https://github.com/zopefoundation/Products.ZCatalog/issues/148
+         https://github.com/zopefoundation/Products.ZCatalog/pull/158
+    """
+    # indexes that we want to use with not queries
+    keywords = self._old__get_object_keywords(obj, attr)
+    if attr in ("Subject",):
+        if not keywords and hasattr(obj, attr):
+            return ("__empty__",)
+    return keywords

src/redturtle/volto/monkey.zcml

@@ -70,7 +70,15 @@
       original="search_for_similar"
       replacement=".monkey.search_for_similar"
       class="plone.app.redirector.browser.FourOhFourView"
-      description="Cancel the seach_for_similiar call when usin volto frontend"
+      description="Cancel the search_for_similiar call when using volto frontend"
+      preserveOriginal="True"
+      />
+
+  <monkey:patch
+      original="_get_object_keywords"
+      replacement=".monkey._get_object_keywords"
+      class="Products.PluginIndexes.KeywordIndex.KeywordIndex.KeywordIndex"
+      description="Manage empty keywords for not queries"
       preserveOriginal="True"
       />
 

src/redturtle/volto/restapi/services/querystringsearch/get.py

@@ -243,7 +243,7 @@ def parse_event_dates(self, parsed_query):
 
     def get_datetime_value(self, value):
         if isinstance(value, DateTime):
-            # return value.utcdatetime()
+            # return value.utcdatetime()
             # manteniamo il possibile timezone
             return value.asdatetime()
         return datetime.fromisoformat(value)