Support DROPINDEX command with DD option#170
Open
sazzad16 wants to merge 1 commit intoRediSearch:masterfrom
Open
Support DROPINDEX command with DD option#170sazzad16 wants to merge 1 commit intoRediSearch:masterfrom
sazzad16 wants to merge 1 commit intoRediSearch:masterfrom
Conversation
gkorland
suggested changes
Oct 12, 2021
| */ | ||
| boolean dropIndex(boolean missingOk); | ||
|
|
||
| boolean dropIndexDD(); |
Contributor
There was a problem hiding this comment.
@sazzad16 should you also add "boolean missingOk"?
Contributor
Author
There was a problem hiding this comment.
@gkorland IMHO, if this is a necessity, it should be supported from RediSearch. If too much convenience is given to users, there is a way greater chance of it being misused.
There was a problem hiding this comment.
why to introduce new method?
why not to add overloaded method
boolean dropIndex(boolean missingOk, boolean keepDocuments)
dropIndexDD name is confusing
and client still use deprecated FT.DROP -> which use different parameter
| assertUnknownIndex(jde); | ||
| } | ||
| try { | ||
| search.getDocuments("doc2", "doc3"); |
Contributor
There was a problem hiding this comment.
Please add another test that also verify docs were deleted with EXISTS or HGET
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #169