-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response example generation for XML and CSV #2347
Open
rishitank
wants to merge
16
commits into
Redocly:main
Choose a base branch
from
Adthena:epic-FBI-287-response-example-generation-for-xml-and-csv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
00256a8
FBI-451: Implement XML example code generation for Redoc
rishitank b13b139
random commit
rishitank 18aadd5
FBI-451: Improve example ID
rishitank eee14dd
FBI-451: Provide `codeSamplesLanguage` as an option
rishitank d1b54be
FBI-451: Provide `codeSamplesLanguage` as an option
rishitank 7eac7e8
Merge branch 'feature-FBI-451-implement-xml-response-example-generati…
rishitank 8e56a3b
FBI-451: clean up
rishitank f29b7ae
FBI-451: clean up
rishitank 69c7fc4
FBI-451: address CR comments
rishitank 55c66f6
Merge pull request #3 from Adthena/feature-FBI-451-implement-xml-resp…
rishitank 068ba23
FBI-459: Implement CSV code sample generation for redoc
rishitank c4133cf
FBI-459: improvements
rishitank 1d4c0dc
FBI-459: improvements
rishitank 8080b33
Merge pull request #5 from Adthena/feature-FBI-459-implement-csv-code…
rishitank 2ef6a02
FBI-287: update readme
rishitank 33f167e
FBI-287: update readme
rishitank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
export const CODE_SAMPLE_LANGUAGES = { | ||
JSON: 'json', | ||
XML: 'xml', | ||
CSV: 'csv', | ||
} as const; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why this is needed? Can we not determine this from the content type? (
application/json
, vsapplication/xml
, vstext/csv
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used to allow the user to control for which media types they want code examples to show up rather than showing all code examples for all media types supported (in case the user doesn't want code examples for certain media types to show up by default).