Move search logic from controller into model #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if type == "needed" || type == "available" | ||
| send(type.to_sym) | ||
| else | ||
| all |
There was a problem hiding this comment.
for some reason I'm not able to find docs for an 'all' method anywhere. I can infer what it's doing, but is this a builtin for rails?
There was a problem hiding this comment.
It's just like calling Post.all, but since we're within Post, we can just say all. This lets us chain them.
For example, you can say Post.where(id: [1,2,3,4,5]).all.all.all.all and it just returns the where.
http://apidock.com/rails/ActiveRecord/Scoping/Named/ClassMethods/all
There was a problem hiding this comment.
I don't know why I didn't realize this haha. Probably would have answered that immediately by opening a terminal :P.
|
👌 @mi-wood ? |
|
lgtm 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we should consider making a Search class, but for now this is OK I think :)