Reduce amount of LLVM code generated for specialized getindex #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
reviewed
Oct 18, 2024
Comment on lines
+52
to
+54
| @noinline function _throw_assert_not_null_error(typename::Symbol) | ||
| throw(AssertionError("Null pointer dereference in Blob{$(typename)}")) | ||
| end |
NHDaly
reviewed
Oct 18, 2024
src/blob.jl
Outdated
| quote | ||
| $(Expr(:meta, :inline)) | ||
| Blob{$(fieldtype(T, i))}(blob + $(blob_offset(T, i))) | ||
| $(Blob{fieldtype(T, i)})(blob, $(blob_offset(T, i))) |
Member
There was a problem hiding this comment.
I think / hope that the size of the code generated shouldn't be affected at all by moving the Blob{T} type construction inside or outside the quote, since it should definitely compile away during Julia's inference phase, and shouldn't show up at all in the LLVM code?
But i think it's fine how you have it too 👍
NHDaly
approved these changes
Oct 18, 2024
Member
NHDaly
left a comment
NHDaly
left a comment
There was a problem hiding this comment.
Cool, this LGTM, if you still want to proceed with it!
robertbuessow
changed the title
robertbuessow
changed the title
Sacha0
reviewed
Jan 21, 2025
Sacha0
reviewed
Jan 21, 2025
Contributor
|
@robertbuessow, I hope you don't mind: @NHDaly and I took the liberty of resolving the merge conflicts following merge of Nathan's recently landed pull request (#28), and added a couple other touchups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less code for getindex boundscheck