fix/HIT-210_Internal-error-when-modifying-role-permissions #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus-relief
approved these changes
Jan 21, 2024
| @@ -159,7 +159,7 @@ const checkFieldPermission = ( | |||
| ) | |||
| ); | |||
| } | |||
| if (!get(field, 'permissions.canSee', []).find((p) => p.equals(role))) { | |||
| if (!get(field, 'permissions.canSee', []).find((p) => p === role)) { | |||
There was a problem hiding this comment.
Suggested change
| if (!get(field, 'permissions.canSee', []).find((p) => p === role)) { | |
| if (!get(field, 'permissions.canSee', []).find((p) => p.toString() === role)) { |
This guarantees that p is a string and not an oid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The permission to allow editing of certain questions in a form creates an internal error.
It happened with a few questions (but not all) and only for updating, not the visibility.
Useful links
Type of change
How Has This Been Tested?
Trying to add permission to allow update the field for fields specified on the ticket.
Screenshots
Before:
Screen.Recording.2024-01-04.at.09.18.48.mov
After:
Screen.Recording.2024-01-04.at.09.16.45.mov
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145