Skip to content

Feat/hit 253 use import fields when importing resource question #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next-oort
Choose a base branch
from

Conversation

NathanHGit
Copy link

@NathanHGit NathanHGit commented Mar 1, 2024

Description

I added the possibility to upload records using the value of an import field instead of the MongoDB object ID when the question is a resource.

Useful links

Type of change

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

I created two forms: form A and form B. In form B, I added a resource question based on a question from form A. I configured the corresponding question in form A as an import field. Then, I tried to upload data using this field instead of the object ID. I also verified if it worked with different formats of the form A field.

Screenshots

Data
image

Result after uploading records
image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@NathanHGit NathanHGit self-assigned this Mar 1, 2024
@NathanHGit NathanHGit added the enhancement New feature or request label Mar 1, 2024
@NathanHGit NathanHGit marked this pull request as ready for review March 4, 2024 11:25
@NathanHGit NathanHGit requested a review from a team March 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant