Typescript, prettier, linting #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
Update dependencies and code style * Format with prettier * Order methods and properties based on accessor type * Add explicit return types to functions * Remove deprecated seekToEnd() function
* Remove `tracks` from Queue constructor * Expose Queue.tracks as public * Transpile as commonjs module
* Use `globalThis` instead of `window` to access `AudioContext`
* Allow currentTrack to be undefined
* Add option to specify `mode` for `fetch()` operations
Contributor
Author
|
Regarding the commonjs vs es module output. My app is based on the latest version of next.js and their support for dynamic import is not quite ready... I get the following error: Just wanted to provide a bit more context to @probablykasper regarding #15 (comment) |
Member
|
I'm going to try and get this merged soon, just a heads up. |
Member
|
I'll have to figure out how to get my changes from #17 into this branch. Probably just go line-by-line and merge manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if you want me to make any changes! As I mentioned in #15, I should have more time than normal to devote to this over the next week or so. Hoping to iron out some issues I've seen with my own project, so there will likely be additional changes incoming.