-
Notifications
You must be signed in to change notification settings - Fork 26
feat(artists): mark as favorite #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,22 @@ | ||
| import RelistenAPI from '@/lib/RelistenAPI'; | ||
| import { getServerFilters } from '@/lib/serverFilterCookies'; | ||
| import ArtistsColumnWithControls from './ArtistsColumnWithControls'; | ||
| import { getServerFavorites } from '@/lib/serverFavoriteCookies'; | ||
|
|
||
| const ArtistsColumn = async () => { | ||
| const [artists, initialFilters] = await Promise.all([ | ||
| const [artists, initialFilters, initialFavorites] = await Promise.all([ | ||
| RelistenAPI.fetchArtists(), | ||
| getServerFilters('root', true), | ||
| getServerFavorites(), | ||
| ]); | ||
|
|
||
| return <ArtistsColumnWithControls artists={artists} initialFilters={initialFilters} />; | ||
| return ( | ||
| <ArtistsColumnWithControls | ||
| artists={artists} | ||
| initialFilters={initialFilters} | ||
| initialFavorites={initialFavorites} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default ArtistsColumn; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| 'use client'; | ||
|
|
||
| import { useCallback, useMemo } from 'react'; | ||
| import useCookie from 'react-use-cookie'; | ||
| import { useRouter } from 'next/navigation'; | ||
|
|
||
| export function useFavoriteState(initialFavorites: string[]) { | ||
| const router = useRouter(); | ||
| const defaultValue = initialFavorites ? JSON.stringify(initialFavorites) : '[]'; | ||
| const [cookieValue, setCookieValue] = useCookie('relisten_favorites:artists', defaultValue); | ||
|
|
||
| const favorites = useMemo(() => { | ||
| try { | ||
| return initialFavorites; | ||
| } catch { | ||
| return [] as string[]; | ||
| } | ||
| }, [initialFavorites]); | ||
|
|
||
| const isFavorite = useCallback( | ||
| (artistId: string) => { | ||
| return favorites.includes(artistId); | ||
| }, | ||
| [favorites] | ||
| ); | ||
|
|
||
| const setFavorites = useCallback( | ||
| (updatedFavorites: string[]) => { | ||
| setCookieValue(JSON.stringify(updatedFavorites), { | ||
| days: 365, | ||
KayBeSee marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| SameSite: 'Lax', | ||
| }); | ||
|
|
||
| router.refresh(); | ||
| }, | ||
| [setCookieValue, router] | ||
| ); | ||
|
|
||
| const toggleFavorite = useCallback( | ||
| (artistId: string) => { | ||
| let updatedFavorites = [...favorites]; | ||
|
|
||
| if (favorites.includes(artistId)) { | ||
| updatedFavorites = updatedFavorites.filter((favorite) => favorite !== artistId); | ||
| } else { | ||
| updatedFavorites.push(artistId); | ||
| } | ||
|
|
||
| setFavorites([...updatedFavorites]); | ||
| }, | ||
| [favorites, setFavorites] | ||
| ); | ||
|
|
||
| return { | ||
| favorites, | ||
| toggleFavorite, | ||
| isFavorite, | ||
| }; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { cookies } from 'next/headers'; | ||
|
|
||
| // Server-side function to read filter cookies | ||
| export async function getServerFavorites(): Promise<string[]> { | ||
| const cookieStore = await cookies(); | ||
|
|
||
| try { | ||
| const value = cookieStore.get('relisten_favorites:artists')?.value; | ||
|
||
| if (value) { | ||
| return JSON.parse(value); | ||
| } | ||
| } catch (error) { | ||
| console.error('Error parsing favorites cookie on server:', error); | ||
| } | ||
|
|
||
| return []; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a really hard time DRYing the
relisten_favorites:artistsvariable to reuse insrc/lib/serverFavoriteCookies.ts. It kept saying the export was a function?Also open to changing naming convention. Figure it was worth scoping to artist so a different cookie name can be used for tracks.