-
Notifications
You must be signed in to change notification settings - Fork 404
Frei/device memory support rebased #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
04715ce
to
82d5580
Compare
squashed WIP commits for latest change |
82d5580
to
cee738e
Compare
removed nonessential nightly tests after rthw internal builder removal |
The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.
8d230cb
to
6702c2b
Compare
addressed those changes with the latest update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
e7d7945
to
4ccdbd2
Compare
e76078a
to
fffe480
Compare
fc8013b
to
20f0ac8
Compare
077457d
to
2743687
Compare
…en using device memory for BVH data.
Fixed missing changes in last commit fix build without SYCL
Fixed forest tutorial Skip pvc tests in nightly.yml fixed unititialized empty geometry commit segfault
fixed coverity issue update gfx-ubuntu24-internal/public.env for CI update linux intenal drivers fix linux release CI fix integration CI
warning: first argument in call to 'memset' is a pointer to non-trivially copyable type
94056a1
to
23dab66
Compare
in device memory, not host memory.
CI is green, I THINK, the documentation doesn't need additional updates after removing the
EMBREE_SYCL_L0_RTAS_BUILDER
cmake flag