Skip to content

Frei/device memory support rebased #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Mar 25, 2025
Merged

Conversation

dopitz
Copy link
Collaborator

@dopitz dopitz commented Jan 20, 2025

CI is green, I THINK, the documentation doesn't need additional updates after removing the EMBREE_SYCL_L0_RTAS_BUILDER cmake flag

@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from 04715ce to 82d5580 Compare January 20, 2025 11:34
@dopitz
Copy link
Collaborator Author

dopitz commented Jan 20, 2025

squashed WIP commits for latest change

@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from 82d5580 to cee738e Compare January 20, 2025 12:45
@dopitz
Copy link
Collaborator Author

dopitz commented Jan 20, 2025

removed nonessential nightly tests after rthw internal builder removal

@svenwoop
Copy link
Collaborator

The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.

Copy link
Collaborator

@svenwoop svenwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.

@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch 2 times, most recently from 8d230cb to 6702c2b Compare January 21, 2025 12:32
@dopitz
Copy link
Collaborator Author

dopitz commented Jan 21, 2025

The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.

addressed those changes with the latest update

svenwoop
svenwoop previously approved these changes Jan 21, 2025
Copy link
Collaborator

@svenwoop svenwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@stefanatwork stefanatwork force-pushed the frei/device_memory_support_rebased branch from e7d7945 to 4ccdbd2 Compare February 28, 2025 15:34
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch 8 times, most recently from e76078a to fffe480 Compare March 7, 2025 14:16
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from fc8013b to 20f0ac8 Compare March 12, 2025 08:01
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch 4 times, most recently from 077457d to 2743687 Compare March 12, 2025 08:54
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from 94056a1 to 23dab66 Compare March 12, 2025 10:51
stefanatwork
stefanatwork previously approved these changes Mar 12, 2025
@stefanatwork stefanatwork self-requested a review March 17, 2025 10:46
@dopitz dopitz merged commit cba03d6 into devel Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants