Skip to content

CI fixes #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025
Merged

CI fixes #527

merged 4 commits into from
Mar 27, 2025

Conversation

kraszkow
Copy link
Contributor

No description provided.

@kraszkow kraszkow requested review from Copilot and dopitz March 26, 2025 15:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR titled "CI fixes" refines the CI workflows by cleaning up unused lines, renaming a misnamed job, and modifying integration test parameters while removing an obsolete test job.

  • Removed extraneous whitespace and the "project: embree" lines for better consistency
  • Corrected a typo in the job name from "istegrate-sycl-linux-DPCPP-test" to "integrate-sycl-linux-DPCPP-test" and updated the test preset
  • Removed the "test-package" job from the release workflow to streamline the pipeline

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/integrate.yml Cleaned up formatting, corrected job name typo, and updated test preset
.github/workflows/release.yml Removed the "test-package" job to simplify the release process
Files not reviewed (1)
  • .gitlab-ci.yml: Language not supported
Comments suppressed due to low confidence (3)

.github/workflows/integrate.yml:575

  • The job name was previously misspelled as 'istegrate-sycl-linux-DPCPP-test'; the correction to 'integrate-sycl-linux-DPCPP-test' improves clarity and consistency.
integrate-sycl-linux-DPCPP-test:

.github/workflows/integrate.yml:587

  • The integration test preset has been changed from 'test-linux-icx' to 'test-linux-clang'; please verify that all related configurations and downstream dependencies support this updated preset.
cmake --preset integrate-sycl-linux-dpcpp -DCMAKE_BUILD_TYPE=Release -DEMBREE_TESTING_INTEGRATION_PRESET=test-linux-clang

.github/workflows/release.yml:265

  • The removal of the 'test-package' job may reduce automated testing coverage for release packages; ensure that its functionality is either redundant or appropriately covered elsewhere.
  test-package:

@kraszkow kraszkow requested a review from Copilot March 26, 2025 15:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces CI fixes intended to improve and streamline the current workflow configurations. The key changes include:

  • Removal of several redundant or unwanted lines (e.g., extraneous blank lines and unused keys such as "project: embree").
  • Correction of a job name typo and updating the integration test preset from "test-linux-icx" to "test-linux-clang".
  • Removal of the test-package job in the release workflow.

Reviewed Changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

File Description
.github/workflows/integrate.yml Cleanup of redundant lines; renaming of a job to fix a typo and update the integration preset for consistency.
.github/workflows/release.yml Removal of the test-package job from the release workflow to simplify the CI process.
Files not reviewed (3)
  • .gitlab-ci.yml: Language not supported
  • scripts/cmake-presets/package.json: Language not supported
  • scripts/cmake-presets/release.json: Language not supported
Comments suppressed due to low confidence (3)

.github/workflows/integrate.yml:575

  • The job name correction from 'istegrate-sycl-linux-DPCPP-test' to 'integrate-sycl-linux-DPCPP-test' is noted; please verify that all dependencies and references to this job are updated accordingly.
  integrate-sycl-linux-DPCPP-test:

.github/workflows/integrate.yml:587

  • Confirm that changing the integration test preset value from 'test-linux-icx' to 'test-linux-clang' is intentional and that downstream configurations align with this update.
        cmake --preset integrate-sycl-linux-dpcpp -DCMAKE_BUILD_TYPE=Release -DEMBREE_TESTING_INTEGRATION_PRESET=test-linux-clang

.github/workflows/release.yml:262

  • The removal of the test-package job may affect package test coverage; please ensure that this change is deliberate and that adequate testing is maintained elsewhere.
Removal of test-package job block

@dopitz dopitz merged commit 3ab1b2e into devel Mar 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants