Update templates.js #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated package.json template to include type: "module". This allows loading Icons as ES Modules in NPM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated package.json template to include
type: "module".This allows loading icons as ES Modules in NPM.
Bug found while testing SSR with Vite + Laravel + Inertia. This PR fixes the issue.
Solution to this issue was provided from: https://stackoverflow.com/a/40021867
Quick and easy fix.
Ps: This is my first time contributing by using a fork. I'm sorry if the description is not much detailed. If there are much easier ways to do the same thing while using oh vue icons that doesn't require a PR, please let me know. At the moment, I am using my own fork for my project, but I hope this allows others to make use of this fix.