Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Set of Tests for Checking that the ResponsiveSafeArea is Working as Expected #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psygo
Copy link

@psygo psygo commented May 7, 2020

Some notes:

  • I'm using a MaterialApp wrapper because the WidgetTester often complains if it isn't testing a Material widget, I don't know why.
  • The first test tests that the contraints inside the LayoutBuilder don't take into account the artificial padding on top (artificial Status Bar). The second one shows that the ResponsiveSafeArea does recognize that difference.
  • I think it would be nicer to have the ResponsiveSafeArea's contraints to be of the same type as the LayoutBuilder's, i.e., BoxConstraints instead of Size, for standardization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant