Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #279

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link
Contributor

cleaning up a couple of issues from https://publint.dev/[email protected]

module and jsnext:main will be ignored since exports is present

@antfu
Copy link
Collaborator

antfu commented Jul 16, 2024

I am not sure how big the userbase magic-string has, especially since it's out for a very long while.

module and jsnext:main will be ignored since exports is present

In that case, I feel it won't hurt to keep those fields:

  • Tools that support exports already ignore them
  • Tools that don't support exports could still pick them up

@benmccann benmccann closed this Aug 28, 2024
@benmccann benmccann deleted the patch-2 branch August 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants