Fix page load bug due to zero connected peers & channels

[ShahanaFarooqui]

Fixes #1511

[gemini-code-assist]

Summary of Changes

Hello @ShahanaFarooqui, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical fix to prevent page load failures in scenarios where a user's node has no active peers or channels. By adding explicit checks and early returns in the backend API handlers for listing channels and peers, the system now gracefully handles empty data sets, ensuring a smoother user experience and preventing unexpected errors during data processing.

Highlights

• Backend API Robustness: Implemented early return logic in the listPeerChannels and getPeers API endpoints. If no channels or peers are found, the API now immediately returns an empty array, preventing potential downstream processing errors.
• Bug Fix for Empty Data Scenarios: Resolved a page load bug that occurred when a node had zero connected peers or channels. The previous implementation might have encountered issues when attempting to process empty lists, which is now gracefully handled.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug where the page would not load if there were no connected peers or channels. The changes in channels.js and channels.ts correctly address an issue where runWithConcurrencyLimit would hang if passed an empty array. However, there's a potential TypeError if the API response body does not contain a channels property. I've added suggestions to make this check safer.

The changes in peers.js and peers.ts seem to be for consistency, but they are redundant as the original code with Promise.all already handled empty arrays correctly. I've added comments to highlight this.

Overall, the PR correctly identifies and fixes a critical bug. My suggestions aim to make the fix more robust and remove unnecessary code.