Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect documentation for bountyGold in match-v5 ChallengesDto #1005

Open
ckousik opened this issue Oct 29, 2024 · 5 comments
Open

Comments

@ckousik
Copy link

ckousik commented Oct 29, 2024

Bug Description
Error in Match-v5 ChallengesDto documentation

Problem Description
bountyGold is documented as an integer but it can be a float.

Expected Result
Documentation is out of date/inconsistent.

Actual Result
bountyGold should be documented as a float.

Developer Impact
Type deserializers generated from the API spec will fail, especially for strongly typed languages.

Repro Steps
Query match-v5 endpoint for LA1_1568057368. bountyGold for one of the Participant structs is a float.

@ckousik
Copy link
Author

ckousik commented Oct 29, 2024

Is related to #982

@MingweiSamuel
Copy link

MingweiSamuel commented Nov 4, 2024

Seems like the data is bugged, why would gold bounty ever be fractional? Did they change how bounty gold works?

(docs should be updated regardless, with note perhaps)

MingweiSamuel added a commit to MingweiSamuel/riotapi-schema that referenced this issue Nov 4, 2024
MingweiSamuel added a commit to MingweiSamuel/Riven that referenced this issue Nov 4, 2024
@noahkohrs
Copy link

Totally agree, it actually affect few other fields in some really specific games.

@ckousik
Copy link
Author

ckousik commented Nov 6, 2024

Seems like the data is wrong, why would gold bounty ever be fractional? Did they change how bounty gold works?

I double checked this. In LA1_1568057368, please see the Participant data for player with game name "Zelt" and tagline "GGZ". Their bountyGold is 17.56436538696289

@MingweiSamuel
Copy link

@noahkohrs What are the match IDs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants