Little Writing Changes to Humanoid Page #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the ChangeState method description, in order to let the users know that It only works on the NetworkOwner of the character side (If the NetworkOwner is a player, It must be done using a localscript owned by that player. If it's server, must be done in a server script
Updates the ChangeState method description, in order to let the users know that It only works on the NetworkOwner of the character side (If the NetworkOwner is a player, It must be done using a localscript owned by that player. If it's server, must be done in a server script
Updates the ChangeState method description, in order to let the users know that It only works on the NetworkOwner of the character side (If the NetworkOwner is a player, It must be done using a localscript owned by that player. If it's server, must be done in a server script
I made some writing changes to the Humanoid page. I know that the ChangeState() method has a long description, but I believe it is easier for beginners to understand.
github-actions
bot
added
the
engine reference
IgnisRBX
reviewed
Jan 30, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
content/en-us/reference/engine/classes/ChangeHistoryService.yaml
Outdated
Show resolved
Hide resolved
content/en-us/reference/engine/classes/CreatorStoreService.yaml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
changes requested
|
Turns out I didn't actually commit your changes from the previous pull request (I just resolved the conversation), so I applied them here instead. This looks good to me now... please post a thumbs up if you agree and I'll merge it. :) |
Seems perfect to me |
IgnisRBX
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In short, I made some changes to the Humanoid page, changing Function word to Method in methods, etc.
I'm aware that the description of ChangeState() is long, but I believe it's easier for beginners to understand.
I have done this Push before, I am just making some changes.
Checks
By submitting your pull request for review, you agree to the following: