Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention local Secrets #1007

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Mention local Secrets #1007

merged 9 commits into from
Jan 31, 2025
+4 −0

Conversation

Ketasaja
Copy link
Contributor

@Ketasaja Ketasaja commented Jan 30, 2025 •
edited
Loading

Changes

https://devforum.roblox.com/t/secrets-store-general-availability/2892154/72


Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@Ketasaja Ketasaja requested a review from a team as a code owner January 30, 2025 19:33
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Jan 30, 2025
@IgnisRBX
Copy link
Contributor

Are the details mentioned for "Security > Secrets" on this page sufficient and accurate enough so that we can just link from HttpService to there? If so, it would be better to just link instead of repeating the info which may change or become outdated in one place but not the other...

@Ketasaja
Copy link
Contributor Author

@IgnisRBX I wasn't familiar with that page, I updated the description to reference that.

@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Jan 31, 2025
@IgnisRBX IgnisRBX merged commit 207c307 into Roblox:main Jan 31, 2025
3 checks passed
@Ketasaja Ketasaja deleted the mention-local-secrets branch January 31, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@IgnisRBX IgnisRBX IgnisRBX approved these changes

Assignees
No one assigned
Labels
changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ketasaja @IgnisRBX