-
Notifications
You must be signed in to change notification settings - Fork 60
Fix/ros2 jazzy #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-ros2
Are you sure you want to change the base?
Fix/ros2 jazzy #72
Conversation
Ah there it is. Found the commit that removed the macros... |
Ah no... The macro that's being used isn't removed in that PR. Can't find the commit that removed the file. |
Is your repo(https://github.com/EricVoll/webrtc_ros/tree/fix/ros2_jazzy) works now? |
No, I got everything to build and it ran, but the repo is using a deprectated webrtc api which chrome doesn't support anymore. In the end I didn't have the time to update the implementation. I ended up writing a custom ros package based on aiortc in python that offers a REST endpoint for signaling and the local node publishes the streams to webrtc and ROS. However, that code is proprietary (company) and I can't open source it. |
Hello everyone, I've worked to find a way to build and run Steps to build
|
Hello @adlimited, you don't have Ninja in your system. It is not installed in the build. You can solve it by installing via apt ( |
Public API Changes
None
Description
Get build to work on Ros2 Jazzy, Ubuntu 24.04.
There are some diffs applied to the cloned webrtc source code (first two bullet points below) I'm not sure how to best apply them in this PR. Maybe apply a patch after pulling the code or something...
Open problems:
webrtc/build/webrtc/src/rtc_base/third_party/base64/base64.h
: add#include <cstdint>
webrtc/build/webrtc/src/build/util/lastchange.py
: replaceutcfromtimestamp
withfromtimestamp
on L318RTC_DISALLOW_COPY_AND_ASSIGN
macro, so currently it's commented out. Edit: Found it and fixed.vision_opencv
and checked out7a47d35
, and renamed a few .h to .hpp - I'm not sure if that's needed though, and I forgot where I read that this is required. Edit: yeah, seems to be needed.#71
After launching:

The webserver launches fine and shows the available topics:
But when trying to establish a connection, it crashes.
Looks like Unified Plan semantics deprecated a few of the older APIs and the webrtc client need to be rewritten...
https://webrtc.org/getting-started/unified-plan-transition-guide
There's a document on how to migrate native C++ applications to Unified Plan, but I can't access the doc...
I found this page that maybe (?) contains a copy of the document https://blog.csdn.net/dotphoenix/article/details/107480133 but no idea.