Construct interface #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missxa
requested changes
Apr 11, 2021
| @@ -8,10 +8,10 @@ | |||
|
|
|||
| from ..utils.utils import Topics, Services | |||
| from roboy_simulation_msgs.msg import Collision | |||
| from roboy_middleware_msgs.msg import EFPose | |||
There was a problem hiding this comment.
EFPose is not a middleware message. it's a control message so needs to be moved. besides, it's not on the roboy3 or dashing branch. will not approve this PR until messages are merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of initialization and stop functionalities for interface with the construct team as specified here.