Skip to content

fix: auto-detect OS/browser color theme on initial load #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

Khizarshah01
Copy link
Contributor

Auto-detect and apply browser/OS theme preference on initial load

Acceptance Criteria fulfillment

  • Detect user’s browser or OS dark/light theme preference automatically on first page load
  • Apply the detected theme without requiring manual toggle by user
  • Update theme correctly on reloads and respect user preference
  • Ensure theme toggle switch remains functional for manual overrides

Fixes #1004

Video/Screenshots

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2025

CLA assistant check
All committers have signed the CLA.

@Spiral-Memory Spiral-Memory added enhancement New feature or request chore a subtle fix labels Jun 1, 2025
@Spiral-Memory Spiral-Memory merged commit 70d714c into RocketChat:develop Jun 1, 2025
4 checks passed
github-actions bot added a commit that referenced this pull request Jun 1, 2025
@Spiral-Memory
Copy link
Collaborator

Thanks for the addition @Khizarshah01
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme toggle doesn’t auto-detect browser/OS theme preference on load
3 participants